linux-kernel - Re: [PATCH] Staging: comedi: mite: added spaces around

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Date:	Tue, 23 Feb 2016 16:48:23 +0000
From:	Ian Abbott <abbotti@....co.uk>
To:	Philippe Loctaux <phil@...lippeloctaux.com>,
	gregkh@...uxfoundation.org
Cc:	hsweeten@...ionengravers.com, devel@...verdev.osuosl.org,
	linux-kernel@...r.kernel.org
Subject: Re: [PATCH] Staging: comedi: mite: added spaces around | and *

On 22/02/16 23:38, Philippe Loctaux wrote:
> Added spaces around | and *, fixing 2 checkpatch checks.
>
> Signed-off-by: Philippe Loctaux <phil@...lippeloctaux.com>
> ---
>   drivers/staging/comedi/drivers/mite.c | 4 ++--
>   1 file changed, 2 insertions(+), 2 deletions(-)
[snip]
> @@ -216,7 +216,7 @@ EXPORT_SYMBOL_GPL(mite_free_ring);
>   struct mite_channel *mite_request_channel_in_range(struct mite_struct *mite,
>   						   struct
>   						   mite_dma_descriptor_ring
> -						   *ring, unsigned min_channel,
> +						   * ring, unsigned min_channel,
>   						   unsigned max_channel)

Actually, that one looks like a false positive by the checkpatch tool. 
I'd expect no space after that '*'.  checkpatch has probably got 
confused by the line-break before the '*'.

It looks a bit ugly anyway.  It would look better if there was a 
line-break before the function name, the same as in 
"drivers/staging/comedi/drivers/mite.h":

struct mite_channel *
mite_request_channel_in_range(struct mite_struct *mite,
			      struct mite_dma_descriptor_ring *ring,
			      unsigned min_channel, unsigned max_channel)

-- 
-=( Ian Abbott @ MEV Ltd.    E-mail: <abbotti@....co.uk> )=-
-=(                          Web: http://www.mev.co.uk/  )=-