linux-kernel - Re: [PATCH v2 2/2] rtc: rtc-pic32: Add PIC32 real time clock driver

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite for Android: free password hash cracker in your pocket

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <56CC9894.7000307@microchip.com>
Date:	Tue, 23 Feb 2016 10:36:20 -0700
From:	Joshua Henderson <joshua.henderson@...rochip.com>
To:	Alexandre Belloni <alexandre.belloni@...e-electrons.com>
CC:	<devicetree@...r.kernel.org>, <linux-kernel@...r.kernel.org>,
	Rob Herring <robh+dt@...nel.org>,
	Pawel Moll <pawel.moll@....com>,
	Mark Rutland <mark.rutland@....com>,
	Ian Campbell <ijc+devicetree@...lion.org.uk>,
	Kumar Gala <galak@...eaurora.org>,
	Alessandro Zummo <a.zummo@...ertech.it>,
	<rtc-linux@...glegroups.com>
Subject: Re: [PATCH v2 2/2] rtc: rtc-pic32: Add PIC32 real time clock driver

Alexandre,

On 02/19/2016 11:17 AM, Alexandre Belloni wrote:
> Hi,
> 
> On 19/02/2016 at 11:09:45 -0700, Joshua Henderson wrote :
>> This driver adds support for the PIC32 real time clock and calendar
>> peripheral:
>> 	- reading and setting time
>> 	- alarms when connected to an IRQ
> 
> Just for confirmation, your probe() fails hard when there are no IRQ
> specified or the IRQ request fails.
> 
> I'll review later but if that the only thing, I can fix it up when
> applying, no need to resend.
> 

probe() does indeed fail when no interrupt is specified:

  ...
  pic32-rtc 1f8c0000.rtc: no irq for alarm
  ...
  hctosys: unable to open rtc device (rtc0)
  ...

If I'm following, I think there right answer here is to just change the wording
in the commit message to be clear that the interrupt is not conditional.  It's
required via binding.  This peripheral has a dedicated interrupt and I can't
imagine a case where it makes sense not to specify it.

I'm fine with something like "- alarms provided by dedicated interrupt" as a
replacement.

Josh