linux-kernel - Re: [PATCH v2] mm: scale kswapd watermarks in proportion to memory

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <20160223015318.GA30924@cmpxchg.org>
Date:	Mon, 22 Feb 2016 17:53:18 -0800
From:	Johannes Weiner <hannes@...xchg.org>
To:	Rik van Riel <riel@...hat.com>
Cc:	Andrew Morton <akpm@...ux-foundation.org>,
	Mel Gorman <mgorman@...e.de>, linux-mm@...ck.org,
	linux-kernel@...r.kernel.org, kernel-team@...com
Subject: Re: [PATCH v2] mm: scale kswapd watermarks in proportion to memory

On Mon, Feb 22, 2016 at 08:36:33PM -0500, Rik van Riel wrote:
> On Mon, 2016-02-22 at 15:33 -0800, Johannes Weiner wrote:
> 
> > Beyond 1G of memory, this will produce bigger watermark steps than 
> 
> Is that supposed to be beyond 16GB?

The old formula formula is

  min = sqrt(kb * 16)
  low = min >> 2

and the new one is

  low = kb * 0.001

and

  sqrt(x/1024 * 16) >> 2 = x/1024 * 0.001

puts x at

  x = 1 << 30

Did I miss something?

> Acked-by: Rik van Riel <riel@...hat.com>

Thanks!