linux-kernel - Re: [PATCH] drivers: staging: rts5208: sd.c: Fix Comparisons should place the constant on the right side of the test warning

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <1456250139.10377.6.camel@perches.com>
Date:	Tue, 23 Feb 2016 09:55:39 -0800
From:	Joe Perches <joe@...ches.com>
To:	Tapan Prakash T <tapanprakasht@...il.com>,
	gregkh@...uxfoundation.org, lambert.quentin@...il.com
Cc:	linux-kernel@...r.kernel.org
Subject: Re: [PATCH] drivers: staging: rts5208: sd.c: Fix Comparisons should
 place the constant on the right side of the test warning

On Tue, 2016-02-23 at 23:14 +0530, Tapan Prakash T wrote:
> Fixed checkpatch.pl warning 'Comparisons should place the constant on
> the right side of the test'
[]
> diff --git a/drivers/staging/rts5208/sd.c b/drivers/staging/rts5208/sd.c
[]
> @@ -1438,7 +1438,7 @@ static int sd_switch_function(struct rtsx_chip *chip, u8 bus_width)
>  
>  #ifdef SUPPORT_SD_LOCK
>  	if ((sd_card->sd_lock_status & SD_SDR_RST)
> -			&& (DDR50_SUPPORT == func_to_switch)
> +			&& (func_to_switch == DDR50_SUPPORT)
>  			&& (sd_card->func_group1_mask & SDR50_SUPPORT_MASK)) {
>  		func_to_switch = SDR50_SUPPORT;
>  		dev_dbg(rtsx_dev(chip), "Using SDR50 instead of DDR50 for SD Lock\n");

It would also be more common to write this with the
logical tests at the end of line like:

 	if ((sd_card->sd_lock_status & SD_SDR_RST) &&
	    (func_to_switch == DDR50_SUPPORT) &&
	    (sd_card->func_group1_mask & SDR50_SUPPORT_MASK)) {