[<prev] [next>] [<thread-prev] [day] [month] [year] [list]
Message-ID: <56CCCBE4.1040809@nod.at>
Date: Tue, 23 Feb 2016 22:15:16 +0100
From: Richard Weinberger <richard@....at>
To: Pavel Machek <pavel@....cz>
Cc: linux-mtd@...ts.infradead.org, dedekind1@...il.com,
adrian.hunter@...el.com, linux-kernel@...r.kernel.org
Subject: Re: [PATCH] ubifs: Implement O_TMPFILE
Am 23.02.2016 um 21:45 schrieb Pavel Machek:
> Hi!
>
>> + ui = ubifs_inode(inode);
>> +
>> + err = ubifs_init_security(dir, inode, &dentry->d_name);
>> + if (err)
>> + goto out_inode;
>> +
>> + mutex_lock(&ui->ui_mutex);
>> + insert_inode_hash(inode);
>> + d_tmpfile(dentry, inode);
>> + ubifs_assert(ui->dirty);
>> + instantiated = 1;
>> + mutex_unlock(&ui->ui_mutex);
>> +
>> + mutex_lock(&dir_ui->ui_mutex);
>> + err = ubifs_jnl_update(c, dir, &dentry->d_name, inode, 1, 0);
>> + if (err)
>> + goto out_cancel;
>> + mutex_unlock(&dir_ui->ui_mutex);
>
> Move the if () below unlock, and make it goto out_inode?
Yes. That's better. :)
Thanks,
//richard
Powered by blists - more mailing lists