linux-kernel - Re: dm: drop unnecessary assignment of md->queue

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <20160224165823.GA15480@redhat.com>
Date:	Wed, 24 Feb 2016 11:58:23 -0500
From:	Mike Snitzer <snitzer@...hat.com>
To:	Bob Liu <bob.liu@...cle.com>
Cc:	linux-kernel@...r.kernel.org, mpatocka@...hat.com, axboe@...com,
	j-nomura@...jp.nec.com, neilb@...e.com, dm-devel@...hat.com
Subject: Re: dm: drop unnecessary assignment of md->queue

On Wed, Feb 24 2016 at  3:15am -0500,
Bob Liu <bob.liu@...cle.com> wrote:

> md->queue and q are the same thing in dm_init_request_based_queue() and
> dm_init_request_based_blk_mq_queue().
> 
> Also drop the temporary struct request_queue *q.

Yeah, I carried the extra assignment just as a form of documentation but
your patch is correct (they aren't needed).  I've rebased your patch
ontop of linux-dm.git's 'dm-4.6' and have staged it in linux-next.