linux-kernel - Re: [PATCH] Staging: rdma: hfi1: verbs_mcast: fixed a brace coding style issue

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <20160224170846.GA32144@phlsvsds.ph.intel.com>
Date:	Wed, 24 Feb 2016 12:08:47 -0500
From:	Dennis Dalessandro <dennis.dalessandro@...el.com>
To:	Jannik Becher <becher.jannik@...il.com>
Cc:	infinipath@...el.com, linux-rdma@...r.kernel.org,
	devel@...verdev.osuosl.org, linux-kernel@...r.kernel.org
Subject: Re: [PATCH] Staging: rdma: hfi1: verbs_mcast: fixed a brace coding style issue

On Sun, Feb 21, 2016 at 04:30:39PM +0100, Jannik Becher wrote:
>Fixed a coding style issue.
>
>Signed-off-by: Jannik Becher <Becher.Jannik@...il.com>
>---
> drivers/staging/rdma/hfi1/verbs_mcast.c | 6 +++---
> 1 file changed, 3 insertions(+), 3 deletions(-)
>
>diff --git a/drivers/staging/rdma/hfi1/verbs_mcast.c b/drivers/staging/rdma/hfi1/verbs_mcast.c
>index afc6b4c..c45d4b1 100644
>--- a/drivers/staging/rdma/hfi1/verbs_mcast.c
>+++ b/drivers/staging/rdma/hfi1/verbs_mcast.c
>@@ -140,11 +140,11 @@ struct hfi1_mcast *hfi1_mcast_find(struct hfi1_ibport *ibp, union ib_gid *mgid)
> 
> 		ret = memcmp(mgid->raw, mcast->mgid.raw,
> 			     sizeof(union ib_gid));
>-		if (ret < 0)
>+		if (ret < 0) {
> 			n = n->rb_left;
>-		else if (ret > 0)
>+		} else if (ret > 0) {
> 			n = n->rb_right;
>-		else {
>+		} else {
> 			atomic_inc(&mcast->refcount);
> 			spin_unlock_irqrestore(&ibp->lock, flags);
> 			goto bail;
>-- 

Doug,

This has been taken care already when I moved the code to rdmavt. Patch is 
submitted in the midst of my other stuff for 4.6. See:
http://www.spinics.net/lists/linux-rdma/msg32802.html

-Denny