linux-kernel - Re: [PATCH 04/50] pinctrl: bcm2835: Use devm_pinctrl

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <d3e4a7ae-6c51-1a2f-8344-8f8b2ff3f5ec@broadcom.com>
Date:	Wed, 24 Feb 2016 10:27:59 -0800
From:	Ray Jui <ray.jui@...adcom.com>
To:	Laxman Dewangan <ldewangan@...dia.com>, linus.walleij@...aro.org,
	corbet@....net, lee@...nel.org
Cc:	linux-doc@...r.kernel.org, linux-kernel@...r.kernel.org,
	linux-gpio@...r.kernel.org, linux-rpi-kernel@...ts.infradead.org,
	linux-arm-kernel@...ts.infradead.org,
	bcm-kernel-feedback-list@...adcom.com,
	linux-mediatek@...ts.infradead.org, Ray Jui <rjui@...adcom.com>
Subject: Re: [PATCH 04/50] pinctrl: bcm2835: Use devm_pinctrl_register() for
 pinctrl registration



On 2/24/2016 5:15 AM, Laxman Dewangan wrote:
> Use devm_pinctrl_register() for pin control registration.
>
> Signed-off-by: Laxman Dewangan <ldewangan@...dia.com>
> Cc: Ray Jui <rjui@...adcom.com>
> ---
>  drivers/pinctrl/bcm/pinctrl-bcm2835.c | 3 +--
>  1 file changed, 1 insertion(+), 2 deletions(-)
>
> diff --git a/drivers/pinctrl/bcm/pinctrl-bcm2835.c b/drivers/pinctrl/bcm/pinctrl-bcm2835.c
> index 0f5997c..25bc4a2 100644
> --- a/drivers/pinctrl/bcm/pinctrl-bcm2835.c
> +++ b/drivers/pinctrl/bcm/pinctrl-bcm2835.c
> @@ -1027,7 +1027,7 @@ static int bcm2835_pinctrl_probe(struct platform_device *pdev)
>  		return err;
>  	}
>
> -	pc->pctl_dev = pinctrl_register(&bcm2835_pinctrl_desc, dev, pc);
> +	pc->pctl_dev = devm_pinctrl_register(dev, &bcm2835_pinctrl_desc, pc);
>  	if (IS_ERR(pc->pctl_dev)) {
>  		gpiochip_remove(&pc->gpio_chip);
>  		return PTR_ERR(pc->pctl_dev);
> @@ -1045,7 +1045,6 @@ static int bcm2835_pinctrl_remove(struct platform_device *pdev)
>  {
>  	struct bcm2835_pinctrl *pc = platform_get_drvdata(pdev);
>
> -	pinctrl_unregister(pc->pctl_dev);
>  	gpiochip_remove(&pc->gpio_chip);
>
>  	return 0;
>

Reviewed-by: Ray Jui <ray.jui@...adcom.com>

Thanks!

Ray