linux-kernel - Re: [PATCH RESEND 1/2] usb: dwc2: Move register save and restore functions

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Date:	Tue, 23 Feb 2016 16:22:31 -0800
From:	Doug Anderson <dianders@...omium.org>
To:	John Youn <johnyoun@...opsys.com>
Cc:	Felipe Balbi <balbi@...nel.org>,
	Alan Stern <stern@...land.harvard.edu>,
	Arnd Bergmann <arnd@...db.de>,
	Greg Kroah-Hartman <gregkh@...uxfoundation.org>,
	"linux-arm-kernel@...ts.infradead.org" 
	<linux-arm-kernel@...ts.infradead.org>,
	Heiko Stuebner <heiko@...ech.de>,
	Stefan Wahren <stefan.wahren@...e.com>,
	Heikki Krogerus <heikki.krogerus@...ux.intel.com>,
	Mathias Nyman <mathias.nyman@...ux.intel.com>,
	"linux-kernel@...r.kernel.org" <linux-kernel@...r.kernel.org>
Subject: Re: [PATCH RESEND 1/2] usb: dwc2: Move register save and restore functions

John,

On Tue, Feb 23, 2016 at 1:33 PM, John Youn <johnyoun@...opsys.com> wrote:
> Move the register save and restore functions into the host and gadget
> specific files.
>
> Signed-off-by: John Youn <johnyoun@...opsys.com>
> ---
>  drivers/usb/dwc2/core.c   | 183 ----------------------------------------------
>  drivers/usb/dwc2/core.h   |  13 ++++
>  drivers/usb/dwc2/gadget.c | 102 ++++++++++++++++++++++++++
>  drivers/usb/dwc2/hcd.c    |  64 ++++++++++++++++
>  4 files changed, 179 insertions(+), 183 deletions(-)

I picked these back to my chromeos-3.14 kernel (with many many dwc2
backports) and I confirmed that I can still compile the kernel, boot
it, and use USB.  I also confirmed no warnings were introduced for me.
I'm only testing HOST, not gadget mode.

I also reviewed the code and agree that it looks good.  Thanks!

Tested-by: Douglas Anderson <dianders@...omium.org>
Reviewed-by: Douglas Anderson <dianders@...omium.org>