lists.openwall.net | lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC | |
Open Source and information security mailing list archives
| ||
|
Date: Wed, 24 Feb 2016 20:21:12 +0100 (CET) From: Thomas Gleixner <tglx@...utronix.de> To: Vikas Shivappa <vikas.shivappa@...el.com> cc: Vikas Shivappa <vikas.shivappa@...ux.intel.com>, x86@...nel.org, linux-kernel@...r.kernel.org, hpa@...or.com, mingo@...nel.org, peterz@...radead.org, ravi.v.shankar@...el.com, tony.luck@...el.com, fenghua.yu@...el.com, kanaka.d.juvva@...el.com, h.peter.anvin@...el.com Subject: Re: [PATCH 2/5] x86/mbm: Intel Memory B/W Monitoring enumeration and init On Wed, 24 Feb 2016, Vikas Shivappa wrote: > On Wed, 24 Feb 2016, Thomas Gleixner wrote: > > You really should register the notifier _AFTER_ registering the pmu. That > > needs to be fixed anyway, because the existing code leaks the notifier AND > > memory in case perf_pmu_register fails. > > Correct, Will fix the notifier leak It's not only a notifier leak. The existing code also leaks memory. Please fix that before adding the new stuff in a seperate patch. Thanks, tglx
Powered by blists - more mailing lists