linux-kernel - Re: [PATCHSET 00/18] perf tools: Add support for hierachy view (v7)

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Date:	Wed, 24 Feb 2016 20:29:32 -0300
From:	Arnaldo Carvalho de Melo <acme@...nel.org>
To:	Namhyung Kim <namhyung@...nel.org>
Cc:	Ingo Molnar <mingo@...nel.org>,
	Peter Zijlstra <peterz@...radead.org>,
	Jiri Olsa <jolsa@...nel.org>,
	LKML <linux-kernel@...r.kernel.org>,
	David Ahern <dsahern@...il.com>,
	Andi Kleen <andi@...stfloor.org>,
	Stephane Eranian <eranian@...gle.com>,
	Wang Nan <wangnan0@...wei.com>,
	Don Zickus <dzickus@...hat.com>,
	Pekka Enberg <penberg@...nel.org>,
	Moinuddin Quadri <moin18@...il.com>
Subject: Re: [PATCHSET 00/18] perf tools: Add support for hierachy view (v7)

Em Thu, Feb 25, 2016 at 12:13:32AM +0900, Namhyung Kim escreveu:
> Hello,
> 
> This patchset implements a new feature that collects hist entries in a
> hierachical manner.  That means lower-level entries belong to an
> upper-level entry.  The entry hierachy is built on the sort keys
> given, so users can set it whatever they want.  It only shows
> top-level entries first, and user can expand/collapse it dynamically.
> 
>  * Changes from v6)
>   - pass srcline, srcfile and trace_output of hist entry properly  (Jiri)
>   - use hist_entry__snprintf_alignment()  (Jiri)

Suggestion for further improvement:

perf top --hierarchy -e sched:sched_switch -s prev_comm,prev_pid,next_comm,next_pid

Will have four levels, would be nice to have just two, perhaps expressed
via:

perf top --hierarchy -e sched:sched_switch -s prev_comm+prev_pid,next_comm+next_pid

Where '+' would work as sort order separator, just like ',' but would
have special meaning for --hierarchy.

What do you think?

- Arnaldo