linux-kernel - Re: [PATCH] arm64: dts: msm8916: Move smem below hwlock

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <20160224060048.GJ21240@tuxbot>
Date:	Tue, 23 Feb 2016 22:00:48 -0800
From:	Bjorn Andersson <bjorn.andersson@...aro.org>
To:	Georgi Djakov <georgi.djakov@...aro.org>
Cc:	andy.gross@...aro.org, devicetree@...r.kernel.org,
	linux-arm-msm@...r.kernel.org, linux-soc@...r.kernel.org,
	linux-kernel@...r.kernel.org
Subject: Re: [PATCH] arm64: dts: msm8916: Move smem below hwlock

On Tue 23 Feb 09:21 PST 2016, Georgi Djakov wrote:

> When the SMEM is probed it defers as it depends on the hardware lock, which
> is not available yet. But the SMD bus and RPM regulators and clocks depend
> on SMEM and they defer too. The problem with this is that the order of
> registering the devices is not optimal and also we may end with messed
> up serial console as the RPM clocks are not registered yet..
> 
> Signed-off-by: Georgi Djakov <georgi.djakov@...aro.org>

Not only do you need the probe order to be "correct", you also need some
luck to have the smd code execute its two workers to initialise the
rpmcc driver before your serial driver is probed. So I don't think we
should merge this upstream.

I tried this on my linux-next tree on db410c and it doesn't hide the
problem for me.

Regards,
Bjorn