linux-kernel - Re: [PATCH v8 5/8] time: Add history to cross timestamp interface supporting slower devices

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <alpine.DEB.2.11.1602241155340.3670@nanos>
Date:	Wed, 24 Feb 2016 11:56:49 +0100 (CET)
From:	Thomas Gleixner <tglx@...utronix.de>
To:	"Christopher S. Hall" <christopher.s.hall@...el.com>
cc:	richardcochran@...il.com, mingo@...hat.com, john.stultz@...aro.org,
	hpa@...or.com, jeffrey.t.kirsher@...el.com, x86@...nel.org,
	linux-kernel@...r.kernel.org, intel-wired-lan@...ts.osuosl.org,
	netdev@...r.kernel.org, kevin.b.stanton@...el.com,
	kevin.j.clarke@...el.com
Subject: Re: [PATCH v8 5/8] time: Add history to cross timestamp interface
 supporting slower devices

On Mon, 22 Feb 2016, Christopher S. Hall wrote:
> +{
> +	struct timekeeper *tk = &tk_core.timekeeper;
> +	bool interp_forward;
> +	u64 corr_raw, corr_real;
> +	int ret;

Once more:

	struct timekeeper *tk = &tk_core.timekeeper;
	u64 corr_raw, corr_real;
	bool interp_forward;
	int ret;

Is way simpler to parse fast.

>  {
>  	struct timekeeper *tk = &tk_core.timekeeper;
> @@ -929,6 +1046,12 @@ int get_device_system_crosststamp(int (*get_time_fn)
>  	ktime_t base_real;
>  	s64 nsec_raw;
>  	s64 nsec_real;
> +	cycles_t cycles;
> +	cycle_t now;
> +	cycle_t interval_start;
> +	unsigned int clock_was_set_seq;
> +	u8 cs_was_changed_seq;
> +	bool do_interp;

Single lines for same types .....

Other than that:

Reviewed-by: Thomas Gleixner <tglx@...utronix.de>