linux-kernel - Re: [PATCH v4 00/11] KVM: x86: track guest page access

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <56CDB32E.60306@redhat.com>
Date:	Wed, 24 Feb 2016 14:42:06 +0100
From:	Paolo Bonzini <pbonzini@...hat.com>
To:	Xiao Guangrong <guangrong.xiao@...ux.intel.com>
Cc:	gleb@...nel.org, mtosatti@...hat.com, kvm@...r.kernel.org,
	linux-kernel@...r.kernel.org, kai.huang@...ux.intel.com,
	jike.song@...el.com
Subject: Re: [PATCH v4 00/11] KVM: x86: track guest page access



On 24/02/2016 10:51, Xiao Guangrong wrote:
> Changelog in v4:
> thanks to Paolo's review, the changes in this version are:
> - comment struct kvm_mmu_page_role to explain the rule bits used by indirect
>   shadow page can not be more than 15 bits
> - simplify overflow detection of track count
> - remove the wrap functions,  kvm_page_track_{add,remove}_page
> - rename kvm_slot_page_track_*_nolock to kvm_slot_page_track_*
> - rename the function, check_mode, to page_track_mode_is_valid and inline it
> - rename kvm_page_track_check_mode to kvm_page_track_is_active
> - check if the notifier list is empty before holding the srcu lock
> - move the patch adjusting write-flooding more earlier

Looks good, thanks!

Paolo