linux-kernel - Re: [PATCH 25/50] pinctrl: ish-pfc: Use devm_pinctrl

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Date:	Wed, 24 Feb 2016 14:59:44 +0100
From:	Geert Uytterhoeven <geert@...ux-m68k.org>
To:	Laxman Dewangan <ldewangan@...dia.com>
Cc:	Linus Walleij <linus.walleij@...aro.org>,
	Jonathan Corbet <corbet@....net>, Lee Jones <lee@...nel.org>,
	"linux-doc@...r.kernel.org" <linux-doc@...r.kernel.org>,
	"linux-kernel@...r.kernel.org" <linux-kernel@...r.kernel.org>,
	"linux-gpio@...r.kernel.org" <linux-gpio@...r.kernel.org>,
	linux-rpi-kernel@...ts.infradead.org,
	"linux-arm-kernel@...ts.infradead.org" 
	<linux-arm-kernel@...ts.infradead.org>,
	bcm-kernel-feedback-list@...adcom.com,
	linux-mediatek@...ts.infradead.org,
	Laurent Pinchart <laurent.pinchart@...asonboard.com>,
	Geert Uytterhoeven <geert+renesas@...der.be>,
	linux-renesas-soc@...r.kernel.org
Subject: Re: [PATCH 25/50] pinctrl: ish-pfc: Use devm_pinctrl_register() for
 pinctrl registration

Hi Laxman,

On Wed, Feb 24, 2016 at 2:15 PM, Laxman Dewangan <ldewangan@...dia.com> wrote:
> Use devm_pinctrl_register() for pin control registration.
>
> Signed-off-by: Laxman Dewangan <ldewangan@...dia.com>
> Cc: Laurent Pinchart <laurent.pinchart@...asonboard.com>
> Cc: Geert Uytterhoeven <geert+renesas@...der.be>
> Cc: linux-renesas-soc@...r.kernel.org

Thanks for your patch!

> index 87b0a59..f17b5fc 100644
> --- a/drivers/pinctrl/sh-pfc/pinctrl.c
> +++ b/drivers/pinctrl/sh-pfc/pinctrl.c
> @@ -692,19 +692,9 @@ int sh_pfc_register_pinctrl(struct sh_pfc *pfc)
>         pmx->pctl_desc.pins = pmx->pins;
>         pmx->pctl_desc.npins = pfc->info->nr_pins;
>
> -       pmx->pctl = pinctrl_register(&pmx->pctl_desc, pfc->dev, pmx);
> +       pmx->pctl = devm_pinctrl_register(pfc->dev, &pmx->pctl_desc, pmx);
>         if (IS_ERR(pmx->pctl))
>                 return PTR_ERR(pmx->pctl);
>
>         return 0;
>  }
> -
> -int sh_pfc_unregister_pinctrl(struct sh_pfc *pfc)
> -{
> -       struct sh_pfc_pinctrl *pmx = pfc->pinctrl;
> -
> -       pinctrl_unregister(pmx->pctl);
> -
> -       pfc->pinctrl = NULL;
> -       return 0;
> -}

There's no longer a need to have sh_pfc.pinctrl, so please remove that field
while you're at it.

Thanks!

Gr{oetje,eeting}s,

                        Geert

--
Geert Uytterhoeven -- There's lots of Linux beyond ia32 -- geert@...ux-m68k.org

In personal conversations with technical people, I call myself a hacker. But
when I'm talking to journalists I just say "programmer" or something like that.
                                -- Linus Torvalds