linux-kernel - Re: [PATCH 21/48] perf record: Extract synthesize code to record_

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <20160224142916.GE27710@krava.redhat.com>
Date:	Wed, 24 Feb 2016 15:29:16 +0100
From:	Jiri Olsa <jolsa@...hat.com>
To:	Wang Nan <wangnan0@...wei.com>
Cc:	Alexei Starovoitov <ast@...nel.org>,
	Arnaldo Carvalho de Melo <acme@...hat.com>,
	Arnaldo Carvalho de Melo <acme@...nel.org>,
	Brendan Gregg <brendan.d.gregg@...il.com>,
	Adrian Hunter <adrian.hunter@...el.com>,
	Cody P Schafer <dev@...yps.com>,
	"David S. Miller" <davem@...emloft.net>,
	He Kuang <hekuang@...wei.com>,
	Jérémie Galarneau 
	<jeremie.galarneau@...icios.com>, Jiri Olsa <jolsa@...nel.org>,
	Kirill Smelkov <kirr@...edi.com>,
	Li Zefan <lizefan@...wei.com>,
	Masami Hiramatsu <masami.hiramatsu.pt@...achi.com>,
	Namhyung Kim <namhyung@...nel.org>,
	Peter Zijlstra <peterz@...radead.org>, pi3orama@....com,
	linux-kernel@...r.kernel.org
Subject: Re: [PATCH 21/48] perf record: Extract synthesize code to
 record__synthesize()

On Mon, Feb 22, 2016 at 09:10:48AM +0000, Wang Nan wrote:

SNIP

> +		err = perf_event__synthesize_auxtrace_info(rec->itr, tool,
> +					session, process_synthesized_event);
> +		if (err)
> +			goto out;
> +	}
> +
> +	err = perf_event__synthesize_kernel_mmap(tool, process_synthesized_event,
> +						 machine);
> +	if (err < 0 && !warned_kmaps) {
> +		warned_kmaps = true;
> +		pr_err("Couldn't record kernel reference relocation symbol\n"
> +		       "Symbol resolution may be skewed if relocation was used (e.g. kexec).\n"
> +		       "Check /proc/kallsyms permission or run as root.\n");
> +	}
> +
> +	err = perf_event__synthesize_modules(tool, process_synthesized_event,
> +					     machine);
> +	if (err < 0 && !warned_modules) {
> +		warned_modules = true;

could you please add logic for warning just once
into separate patch, so this is just pure move?

also we have WARN_ONCE macro in perf

thanks,
jirka