linux-kernel - Re: [PATCH] drm/amd: Do not make DRM_AMD

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <CAMuHMdUWzBzV2o6oB6VHbRrwhBj417Rm9T2y1SKg1rw3Wy7-Xg@mail.gmail.com>
Date:	Wed, 24 Feb 2016 15:58:23 +0100
From:	Geert Uytterhoeven <geert@...ux-m68k.org>
To:	"Deucher, Alexander" <Alexander.Deucher@....com>
Cc:	Geert Uytterhoeven <geert+renesas@...der.be>,
	David Airlie <airlied@...ux.ie>,
	"Bayyavarapu, Maruthi" <Maruthi.Bayyavarapu@....com>,
	"dri-devel@...ts.freedesktop.org" <dri-devel@...ts.freedesktop.org>,
	"linux-kernel@...r.kernel.org" <linux-kernel@...r.kernel.org>
Subject: Re: [PATCH] drm/amd: Do not make DRM_AMD_ACP default to y

Hi Alex,

On Wed, Feb 24, 2016 at 3:48 PM, Deucher, Alexander
<Alexander.Deucher@....com> wrote:
>> -----Original Message-----
>> From: Geert Uytterhoeven [mailto:geert+renesas@...der.be]
>> Sent: Wednesday, February 24, 2016 3:14 AM
>> To: David Airlie; Deucher, Alexander; Bayyavarapu, Maruthi
>> Cc: dri-devel@...ts.freedesktop.org; linux-kernel@...r.kernel.org; Geert
>> Uytterhoeven
>> Subject: [PATCH] drm/amd: Do not make DRM_AMD_ACP default to y
>>
>> By default, not only this driver is enabled on all platforms, but also
>> generic PM Domains and Multi-Function Devices.
>>
>> Drop the "default y" to fix this.
>
> I guess I don't really care per se, but why is this an issue?

Because it causes kernel bloat on all platforms that are not AMD SoCs.
I noticed the option and the selected options were suddenly enabled when
running "make ARCH=sh se7724_defconfig".

As a general use, never use "default y", unless the system fails completely
in the absence of the module. Even then, there should be some dependencies
listed.

Gr{oetje,eeting}s,

                        Geert

--
Geert Uytterhoeven -- There's lots of Linux beyond ia32 -- geert@...ux-m68k.org

In personal conversations with technical people, I call myself a hacker. But
when I'm talking to journalists I just say "programmer" or something like that.
                                -- Linus Torvalds