linux-kernel - Re: [PATCH] watchdog: orion: Depend on 32-bit ARM

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <56CDCC77.9040709@roeck-us.net>
Date:	Wed, 24 Feb 2016 07:29:59 -0800
From:	Guenter Roeck <linux@...ck-us.net>
To:	Thierry Reding <thierry.reding@...il.com>,
	Wim Van Sebroeck <wim@...ana.be>
Cc:	linux-watchdog@...r.kernel.org, linux-kernel@...r.kernel.org
Subject: Re: [PATCH] watchdog: orion: Depend on 32-bit ARM

On 02/24/2016 06:22 AM, Thierry Reding wrote:
> From: Thierry Reding <treding@...dia.com>
>
> The driver uses the atomic_io_modify() function to update registers, but
> that function is only available on 32-bit ARM. Recent changes have added
> ARCH_MVEBU support to 64-bit ARM and hence allowed this driver to build
> on 64-bit ARM where this function isn't available and thereby causing
> allmodconfig builds to break.
>
> Signed-off-by: Thierry Reding <treding@...dia.com>

Reviewed-by: Guenter Roeck <linux@...ck-us.net>

> ---
>   drivers/watchdog/Kconfig | 1 +
>   1 file changed, 1 insertion(+)
>
> diff --git a/drivers/watchdog/Kconfig b/drivers/watchdog/Kconfig
> index 9289da313d98..cfec157488b1 100644
> --- a/drivers/watchdog/Kconfig
> +++ b/drivers/watchdog/Kconfig
> @@ -399,6 +399,7 @@ config DAVINCI_WATCHDOG
>   config ORION_WATCHDOG
>   	tristate "Orion watchdog"
>   	depends on ARCH_ORION5X || ARCH_DOVE || MACH_DOVE || ARCH_MVEBU
> +	depends on ARM
>   	select WATCHDOG_CORE
>   	help
>   	  Say Y here if to include support for the watchdog timer
>