linux-kernel - Re: [PATCH] libata: Align ata

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Date:	Thu, 25 Feb 2016 16:37:51 -0500
From:	Tejun Heo <tj@...nel.org>
To:	Harvey Hunt <harvey.hunt@...tec.com>
Cc:	linux-ide@...r.kernel.org, linux-kernel@...r.kernel.org,
	"# 2 . 6 . 18" <stable@...r.kernel.org>
Subject: Re: [PATCH] libata: Align ata_device's id on a cacheline

On Wed, Feb 24, 2016 at 03:16:43PM +0000, Harvey Hunt wrote:
> The id buffer in ata_device is a DMA target, but it isn't explicitly
> cacheline aligned. Due to this, adjacent fields can be overwritten with
> stale data from memory on non coherent architectures. As a result, the
> kernel is sometimes unable to communicate with an ATA device.
> 
> Fix this by ensuring that the id buffer is cacheline aligned.
> 
> This issue is similar to that fixed by Commit 84bda12af31f
> ("libata: align ap->sector_buf").
> 
> Signed-off-by: Harvey Hunt <harvey.hunt@...tec.com>
> Cc: linux-kernel@...r.kernel.org
> Cc: <stable@...r.kernel.org> # 2.6.18

Applied to libata/for-4.5-fixes.

Thanks.

-- 
tejun