linux-kernel - Re: [PATCH 2/5] all: introduce COMPAT_WRAPPER option and enable it for s390

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <20160225221018.GA5950@osiris>
Date:	Thu, 25 Feb 2016 23:10:18 +0100
From:	Heiko Carstens <heiko.carstens@...ibm.com>
To:	Yury Norov <ynorov@...iumnetworks.com>
Cc:	linux-arch@...r.kernel.org, linux-s390@...r.kernel.org,
	arnd@...db.de, linux-doc@...r.kernel.org,
	Prasun.Kapoor@...iumnetworks.com, catalin.marinas@....com,
	pinskia@...il.com, Nathan_Lynch@...tor.com,
	linux-kernel@...r.kernel.org, agraf@...e.de,
	klimov.linux@...il.com, broonie@...nel.org,
	bamvor.zhangjian@...wei.com, joseph@...esourcery.com,
	linux-arm-kernel@...ts.infradead.org,
	christoph.muellner@...obroma-systems.com
Subject: Re: [PATCH 2/5] all: introduce COMPAT_WRAPPER option and enable it
 for s390

On Thu, Feb 25, 2016 at 11:19:26PM +0300, Yury Norov wrote:
> On Thu, Feb 25, 2016 at 09:49:43AM +0100, Heiko Carstens wrote:
> > On Wed, Feb 24, 2016 at 09:34:11PM +0300, Yury Norov wrote:
> > > Signed-off-by: Yury Norov <ynorov@...iumnetworks.com>
> > > ---
> > >  arch/Kconfig      | 4 ++++
> > >  arch/s390/Kconfig | 1 +
> > >  2 files changed, 5 insertions(+)
> > > 
> > > diff --git a/arch/Kconfig b/arch/Kconfig
> > > index f6b649d..6393093 100644
> > > --- a/arch/Kconfig
> > > +++ b/arch/Kconfig
> > > @@ -583,6 +583,10 @@ config HAVE_COPY_THREAD_TLS
> > >  	  normal C parameter passing, rather than extracting the syscall
> > >  	  argument from pt_regs.
> > > 
> > > +config COMPAT_WRAPPER
> > > +	bool
> > > +	depends on COMPAT
> > > +
> > >  #
> > >  # ABI hall of shame
> > >  #
> > > diff --git a/arch/s390/Kconfig b/arch/s390/Kconfig
> > > index 3be9c83..082b861 100644
> > > --- a/arch/s390/Kconfig
> > > +++ b/arch/s390/Kconfig
> > > @@ -333,6 +333,7 @@ config COMPAT
> > >  	select COMPAT_BINFMT_ELF if BINFMT_ELF
> > >  	select ARCH_WANT_OLD_COMPAT_IPC
> > >  	select COMPAT_OLD_SIGACTION
> > > +	select COMPAT_WRAPPER
> > >  	depends on MULTIUSER
> > >  	help
> > >  	  Select this option if you want to enable your system kernel to
> > 
> > Maybe merge this into patch 4/5?
> 
> Then bisectability will suffer, as next patch needs COMPAT_WRAPPER
> enabled.

Oh, right. I didn't realize that you put the macros between an
#ifdef CONFIG_COMPAT_WRAPPER . It's not strictly needed, but it
doesn't hurt as well.