linux-kernel - Re: [PATCHSET 00/18] perf tools: Add support for hierachy view (v7)

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <20160225022754.GC18880@sejong>
Date:	Thu, 25 Feb 2016 11:27:54 +0900
From:	Namhyung Kim <namhyung@...nel.org>
To:	Arnaldo Carvalho de Melo <acme@...nel.org>
CC:	Ingo Molnar <mingo@...nel.org>,
	Peter Zijlstra <peterz@...radead.org>,
	Jiri Olsa <jolsa@...nel.org>,
	LKML <linux-kernel@...r.kernel.org>,
	David Ahern <dsahern@...il.com>,
	Andi Kleen <andi@...stfloor.org>,
	Stephane Eranian <eranian@...gle.com>,
	Wang Nan <wangnan0@...wei.com>,
	Don Zickus <dzickus@...hat.com>,
	Pekka Enberg <penberg@...nel.org>,
	Moinuddin Quadri <moin18@...il.com>
Subject: Re: [PATCHSET 00/18] perf tools: Add support for hierachy view (v7)

On Wed, Feb 24, 2016 at 10:22:07PM -0300, Arnaldo Carvalho de Melo wrote:
> Em Thu, Feb 25, 2016 at 12:13:32AM +0900, Namhyung Kim escreveu:
> > Hello,
> > 
> > This patchset implements a new feature that collects hist entries in a
> > hierachical manner.  That means lower-level entries belong to an
> > upper-level entry.  The entry hierachy is built on the sort keys
> > given, so users can set it whatever they want.  It only shows
> > top-level entries first, and user can expand/collapse it dynamically.
> 
> Some oddity: look at the line with 3.92%, it shows just the DSO... Ok, there
> probably are no symbols above the specified threshold (--percent-limit 1), but
> it is strange none the less, perhaps we can add something like:
> 
> #       Overhead  Command / Shared Object / Symbol      
> # ..............  ..............................................................................................................................................
> #
>     72.83%        cc1       
>        60.88%        cc1                    
>            1.92%        [.] bitmap_set_bit
>         7.37%        libc-2.22.so           
>            2.90%        [.] _int_malloc
>             |          
>              --2.04%--0
>                        _int_malloc
> 
>            1.13%        [.] _int_free
>         3.92%        [kernel.vmlinux]       
>            (no symbols >= 1%)

Hmm.. makes sense.  But the problem is that these non-entry lines
hinder counting the number of (printed) entries which might break the
output in some way.  Maybe I can use a mock entry to work around it.
I'll try to do something. :)

Thanks,
Namhyung


> 
> 
> Original output:
> 
> 
> [acme@...et linux]$ perf report --hierarchy --percent-limit 1 | head -30
> no symbols found in /usr/bin/gcc, maybe install a debug package?
> # To display the perf.data header info, please use --header/--header-only options.
> #
> #
> # Total Lost Samples: 0
> #
> # Samples: 10K of event 'cycles:ppp'
> # Event count (approx.): 6703622666
> #
> #       Overhead  Command / Shared Object / Symbol      
> # ..............  ..............................................................................................................................................
> #
>     72.83%        cc1       
>        60.88%        cc1                    
>            1.92%        [.] bitmap_set_bit
>         7.37%        libc-2.22.so           
>            2.90%        [.] _int_malloc
>             |          
>              --2.04%--0
>                        _int_malloc
> 
>            1.13%        [.] _int_free
>         3.92%        [kernel.vmlinux]       
>      5.96%        as        
>         3.19%        [kernel.vmlinux]       
>         1.31%        as                     
>      5.33%        conf      
>         2.39%        conf                   
>         1.52%        libc-2.22.so           
>         1.37%        [kernel.vmlinux]       
>      4.88%        ld        
> [acme@...et linux]$