lists.openwall.net | lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC | |
Open Source and information security mailing list archives
| ||
|
Date: Wed, 24 Feb 2016 21:49:52 -0800 From: tip-bot for Josh Poimboeuf <tipbot@...or.com> To: linux-tip-commits@...r.kernel.org Cc: acme@...nel.org, torvalds@...ux-foundation.org, brgerst@...il.com, mingo@...nel.org, palves@...hat.com, matt@...eblueprint.co.uk, namhyung@...il.com, akpm@...ux-foundation.org, luto@...capital.net, luto@...nel.org, peterz@...radead.org, chris.j.arges@...onical.com, mmarek@...e.cz, hpa@...or.com, dvlasenk@...hat.com, bp@...e.de, bernd@...rovitsch.priv.at, jpoimboe@...hat.com, linux-kernel@...r.kernel.org, jslaby@...e.cz, tglx@...utronix.de, bp@...en8.de Subject: [tip:x86/debug] x86/asm/efi: Create a stack frame in efi_call() Commit-ID: 779c433b8ea5c9fdfb892265b2ca6213d1f12ff8 Gitweb: http://git.kernel.org/tip/779c433b8ea5c9fdfb892265b2ca6213d1f12ff8 Author: Josh Poimboeuf <jpoimboe@...hat.com> AuthorDate: Thu, 21 Jan 2016 16:49:23 -0600 Committer: Ingo Molnar <mingo@...nel.org> CommitDate: Wed, 24 Feb 2016 08:35:43 +0100 x86/asm/efi: Create a stack frame in efi_call() efi_call() is a callable non-leaf function which doesn't honor CONFIG_FRAME_POINTER, which can result in bad stack traces. Create a stack frame for it when CONFIG_FRAME_POINTER is enabled. Signed-off-by: Josh Poimboeuf <jpoimboe@...hat.com> Reviewed-by: Matt Fleming <matt@...eblueprint.co.uk> Reviewed-by: Borislav Petkov <bp@...e.de> Cc: Andrew Morton <akpm@...ux-foundation.org> Cc: Andy Lutomirski <luto@...capital.net> Cc: Andy Lutomirski <luto@...nel.org> Cc: Arnaldo Carvalho de Melo <acme@...nel.org> Cc: Bernd Petrovitsch <bernd@...rovitsch.priv.at> Cc: Borislav Petkov <bp@...en8.de> Cc: Brian Gerst <brgerst@...il.com> Cc: Chris J Arges <chris.j.arges@...onical.com> Cc: Denys Vlasenko <dvlasenk@...hat.com> Cc: H. Peter Anvin <hpa@...or.com> Cc: Jiri Slaby <jslaby@...e.cz> Cc: Linus Torvalds <torvalds@...ux-foundation.org> Cc: Michal Marek <mmarek@...e.cz> Cc: Namhyung Kim <namhyung@...il.com> Cc: Pedro Alves <palves@...hat.com> Cc: Peter Zijlstra <peterz@...radead.org> Cc: Thomas Gleixner <tglx@...utronix.de> Cc: live-patching@...r.kernel.org Link: http://lkml.kernel.org/r/2294b6fad60eea4cc862eddc8e98a1324e6eeeca.1453405861.git.jpoimboe@redhat.com Signed-off-by: Ingo Molnar <mingo@...nel.org> --- arch/x86/platform/efi/efi_stub_64.S | 3 +++ 1 file changed, 3 insertions(+) diff --git a/arch/x86/platform/efi/efi_stub_64.S b/arch/x86/platform/efi/efi_stub_64.S index 86d0f9e..0df2dcc 100644 --- a/arch/x86/platform/efi/efi_stub_64.S +++ b/arch/x86/platform/efi/efi_stub_64.S @@ -11,6 +11,7 @@ #include <asm/msr.h> #include <asm/processor-flags.h> #include <asm/page_types.h> +#include <asm/frame.h> #define SAVE_XMM \ mov %rsp, %rax; \ @@ -74,6 +75,7 @@ .endm ENTRY(efi_call) + FRAME_BEGIN SAVE_XMM mov (%rsp), %rax mov 8(%rax), %rax @@ -88,6 +90,7 @@ ENTRY(efi_call) RESTORE_PGT addq $48, %rsp RESTORE_XMM + FRAME_END ret ENDPROC(efi_call)
Powered by blists - more mailing lists