linux-kernel - RE: [PATCH v14 01/22] tracing: Update some tracing

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite for Android: free password hash cracker in your pocket

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <50399556C9727B4D88A595C8584AAB37B4E196E4@GSjpTKYDCembx32.service.hitachi.net>
Date:	Thu, 25 Feb 2016 05:55:22 +0000
From:	平松雅巳 / HIRAMATU，MASAMI 
	<masami.hiramatsu.pt@...achi.com>
To:	"'Tom Zanussi'" <tom.zanussi@...ux.intel.com>,
	"rostedt@...dmis.org" <rostedt@...dmis.org>
CC:	"namhyung@...nel.org" <namhyung@...nel.org>,
	"josh@...htriplett.org" <josh@...htriplett.org>,
	"andi@...stfloor.org" <andi@...stfloor.org>,
	"mathieu.desnoyers@...icios.com" <mathieu.desnoyers@...icios.com>,
	"peterz@...radead.org" <peterz@...radead.org>,
	"linux-kernel@...r.kernel.org" <linux-kernel@...r.kernel.org>
Subject: RE: [PATCH v14 01/22] tracing: Update some tracing_map constants
 and comments

Hi Tom,

From: Tom Zanussi [mailto:tom.zanussi@...ux.intel.com]
>
>Make it clear exactly how many keys and values are supported through
>better defines, and add 1 to the vals count, since normally clients
>want support for at least a hitcount and two other values.

OK, but would that (increment the vals count) be possible to apply
later patch? I think we'd better make this a cleanup patch.

Thank you,

>
>Also, note the error return value for tracing_map_add_key/val_field()
>in the comments.
>
>Signed-off-by: Tom Zanussi <tom.zanussi@...ux.intel.com>
>---
> kernel/trace/tracing_map.c | 4 ++--
> kernel/trace/tracing_map.h | 5 +++--
> 2 files changed, 5 insertions(+), 4 deletions(-)
>
>diff --git a/kernel/trace/tracing_map.c b/kernel/trace/tracing_map.c
>index dd6401d..e0f1729 100644
>--- a/kernel/trace/tracing_map.c
>+++ b/kernel/trace/tracing_map.c
>@@ -163,7 +163,7 @@ static int tracing_map_add_field(struct tracing_map *map,
>  * tracing_map_update_sum() or reading it via tracing_map_read_sum().
>  *
>  * Return: The index identifying the field in the map and associated
>- * tracing_map_elts.
>+ * tracing_map_elts, or -EINVAL on error.
>  */
> int tracing_map_add_sum_field(struct tracing_map *map)
> {
>@@ -184,7 +184,7 @@ int tracing_map_add_sum_field(struct tracing_map *map)
>  * the key referenced by this key field resides.
>  *
>  * Return: The index identifying the field in the map and associated
>- * tracing_map_elts.
>+ * tracing_map_elts, or -EINVAL on error.
>  */
> int tracing_map_add_key_field(struct tracing_map *map,
> 			      unsigned int offset,
>diff --git a/kernel/trace/tracing_map.h b/kernel/trace/tracing_map.h
>index 7571825..b575d0b 100644
>--- a/kernel/trace/tracing_map.h
>+++ b/kernel/trace/tracing_map.h
>@@ -5,9 +5,10 @@
> #define TRACING_MAP_BITS_MAX		17
> #define TRACING_MAP_BITS_MIN		7
>
>-#define TRACING_MAP_FIELDS_MAX		4
> #define TRACING_MAP_KEYS_MAX		2
>-
>+#define TRACING_MAP_VALS_MAX		3
>+#define TRACING_MAP_FIELDS_MAX		(TRACING_MAP_KEYS_MAX + \
>+					 TRACING_MAP_VALS_MAX)
> #define TRACING_MAP_SORT_KEYS_MAX	2
>
> typedef int (*tracing_map_cmp_fn_t) (void *val_a, void *val_b);
>--
>1.9.3