linux-kernel - Re: [PATCH 0/2] usb: dwc2: Remove host and gadget only code from core

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <87r3g1i7x9.fsf@ti.com>
Date:	Thu, 25 Feb 2016 09:08:18 +0200
From:	Felipe Balbi <balbi@...nel.org>
To:	Doug Anderson <dianders@...omium.org>
Cc:	John Youn <John.Youn@...opsys.com>,
	Alan Stern <stern@...land.harvard.edu>,
	Arnd Bergmann <arnd@...db.de>,
	Greg Kroah-Hartman <gregkh@...uxfoundation.org>,
	"linux-arm-kernel\@lists.infradead.org" 
	<linux-arm-kernel@...ts.infradead.org>,
	Heiko Stuebner <heiko@...ech.de>,
	Stefan Wahren <stefan.wahren@...e.com>,
	Heikki Krogerus <heikki.krogerus@...ux.intel.com>,
	Mathias Nyman <mathias.nyman@...ux.intel.com>,
	"linux-kernel\@vger.kernel.org" <linux-kernel@...r.kernel.org>
Subject: Re: [PATCH 0/2] usb: dwc2: Remove host and gadget only code from core


Hi,

Doug Anderson <dianders@...omium.org> writes:
>> John Youn <John.Youn@...opsys.com> writes:
>>> On 2/23/2016 12:35 AM, John Youn wrote:
>>>> This series moves the host/gadget-specific code from core.c to hcd.c
>>>> and gadget.c so that they will be compiled only when their respective
>>>> configurations are selected, or in DRD.
>>>>
>>>> This is mostly just a straight move of the code. I have also added
>>>> some comments to group related functions together.
>>>>
>>>> Compiled and tested in all three modes.
>>>>
>>>> This should also solve the issue reported here:
>>>> http://marc.info/?l=linux-usb&m=145591813410106&w=2
>>>>
>>>> Although I wasn't able to test it... couldn't figure out how to
>>>> disable CONFIG_USB and enable DWC2 in gadget mode.
>>>>
>>>> Felipe,
>>>>
>>>> This should be applied after Doug's series on your testing/next
>>>> branch.
>>>>
>>>>
>>>
>>> Hi Felipe,
>>>
>>> Patch 2/2 is triggering our corporate mail filters however I try to
>>> send it. I'll look into this with IT tomorrow, maybe have to send it
>>> from another account.
>>
>> okay, I don't have patch 2/2. 1/2 is now in testing/next
>
> Perhaps John's solution for working around his company's mail filters
> somehow sent it to your SPAM folder?  I saw his repost of v1 at on
> patchwork.  GMail put them in my inbox but marked them slightly
> different, saying they were from "John Youn via messagingengine.com"
>
> 8396481 New          [RESEND,1/2] usb: dwc2: Move register save and
> restore functions
> 8396491 New          [RESEND,2/2] usb: dwc2: Move host-specific core
> functions into hcd.c
>
> ...I reviewed both 1/2 and 2/2.  For 1/2 I added my reviewed-by /
> tested-by.  For 2/2 I requested some nitfixes.  John posted v2 at:
>
> 8398461 New          [v2,1/2] usb: dwc2: Move register save and
> restore functions
> 8398471 New          [v2,2/2] usb: dwc2: Move host-specific core
> functions into hcd.c
>
> v2 of 2/2 looks good to me.  All patches can be found at
> <https://patchwork.kernel.org/patch/<PATCHNUM>/>, like:
>
> https://patchwork.kernel.org/patch/8398461/
> https://patchwork.kernel.org/patch/8398471/

thanks, after I replied here I refreshed my inbox and there they were
:-) they're both in my testing/next.

cheers

-- 
balbi

Download attachment "signature.asc" of type "application/pgp-signature" (819 bytes)