linux-kernel - Re: [PATCH] ALSA: hda - Fixing background noise on Dell Inspiron 3162

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <s5hziupyztn.wl-tiwai@suse.de>
Date:	Thu, 25 Feb 2016 09:11:16 +0100
From:	Takashi Iwai <tiwai@...e.de>
To:	"Kai-Heng Feng" <kaihengfeng@...il.com>
Cc:	<alsa-devel@...a-project.org>,
	"Kai-Heng Feng" <kai.heng.feng@...onical.com>,
	<linux-kernel@...r.kernel.org>
Subject: Re: [PATCH] ALSA: hda - Fixing background noise on Dell Inspiron 3162

On Thu, 25 Feb 2016 08:19:38 +0100,
Kai-Heng Feng wrote:
> 
> After login to the desktop on Dell Inspiron 3162,
> there's a very loud background noise comes from the builtin speaker.
> The noise does not go away even if the speaker is muted.
> 
> The noise disappears after using the aamix fixup.
> 
> Codec: Realtek ALC3234
> Address: 0
> AFG Function Id: 0x1 (unsol 1)
>     Vendor Id: 0x10ec0255
>     Subsystem Id: 0x10280725
>     Revision Id: 0x100002
>     No Modem Function Group found
> 
> BugLink: http://bugs.launchpad.net/bugs/1549620
> Signed-off-by: Kai-Heng Feng <kai.heng.feng@...onical.com>

Applied, thanks.


Takashi

> ---
>  sound/pci/hda/patch_realtek.c | 8 ++++++++
>  1 file changed, 8 insertions(+)
> 
> diff --git a/sound/pci/hda/patch_realtek.c b/sound/pci/hda/patch_realtek.c
> index efd4980..72fa58d 100644
> --- a/sound/pci/hda/patch_realtek.c
> +++ b/sound/pci/hda/patch_realtek.c
> @@ -4749,6 +4749,7 @@ enum {
>  	ALC256_FIXUP_DELL_XPS_13_HEADPHONE_NOISE,
>  	ALC293_FIXUP_LENOVO_SPK_NOISE,
>  	ALC233_FIXUP_LENOVO_LINE2_MIC_HOTKEY,
> +	ALC255_FIXUP_DELL_SPK_NOISE,
>  };
>  
>  static const struct hda_fixup alc269_fixups[] = {
> @@ -5368,6 +5369,12 @@ static const struct hda_fixup alc269_fixups[] = {
>  		.type = HDA_FIXUP_FUNC,
>  		.v.func = alc233_fixup_lenovo_line2_mic_hotkey,
>  	},
> +	[ALC255_FIXUP_DELL_SPK_NOISE] = {
> +		.type = HDA_FIXUP_FUNC,
> +		.v.func = alc_fixup_disable_aamix,
> +		.chained = true,
> +		.chain_id = ALC255_FIXUP_DELL1_MIC_NO_PRESENCE
> +	},
>  };
>  
>  static const struct snd_pci_quirk alc269_fixup_tbl[] = {
> @@ -5410,6 +5417,7 @@ static const struct snd_pci_quirk alc269_fixup_tbl[] = {
>  	SND_PCI_QUIRK(0x1028, 0x06df, "Dell", ALC293_FIXUP_DISABLE_AAMIX_MULTIJACK),
>  	SND_PCI_QUIRK(0x1028, 0x06e0, "Dell", ALC293_FIXUP_DISABLE_AAMIX_MULTIJACK),
>  	SND_PCI_QUIRK(0x1028, 0x0704, "Dell XPS 13", ALC256_FIXUP_DELL_XPS_13_HEADPHONE_NOISE),
> +	SND_PCI_QUIRK(0x1028, 0x0725, "Dell Inspiron 3162", ALC255_FIXUP_DELL_SPK_NOISE),
>  	SND_PCI_QUIRK(0x1028, 0x164a, "Dell", ALC293_FIXUP_DELL1_MIC_NO_PRESENCE),
>  	SND_PCI_QUIRK(0x1028, 0x164b, "Dell", ALC293_FIXUP_DELL1_MIC_NO_PRESENCE),
>  	SND_PCI_QUIRK(0x103c, 0x1586, "HP", ALC269_FIXUP_HP_MUTE_LED_MIC2),
> -- 
> 2.5.0
> 
>