linux-kernel - Re: [PATCH 1/2] gpio: xgene: fix type of variable containing error codes

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Date:	Thu, 25 Feb 2016 11:00:29 +0100
From:	Linus Walleij <linus.walleij@...aro.org>
To:	Andrzej Hajda <a.hajda@...sung.com>
Cc:	Alexandre Courbot <gnurou@...il.com>,
	"open list:GPIO SUBSYSTEM" <linux-gpio@...r.kernel.org>,
	Bartlomiej Zolnierkiewicz <b.zolnierkie@...sung.com>,
	Marek Szyprowski <m.szyprowski@...sung.com>,
	open list <linux-kernel@...r.kernel.org>
Subject: Re: [PATCH 1/2] gpio: xgene: fix type of variable containing error codes

On Tue, Feb 23, 2016 at 7:45 AM, Andrzej Hajda <a.hajda@...sung.com> wrote:

> ret variable can contain error values and is compared with zero.
> Its type must be signed.
>
> The problem has been detected using coccinelle script
> scripts/coccinelle/tests/unsigned_lesser_than_zero.cocci
>
> Signed-off-by: Andrzej Hajda <a.hajda@...sung.com>

Patch applied as obviously correct.

Yours,
Linus Walleij