lists.openwall.net | lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC | |
Open Source and information security mailing list archives
| ||
|
Date: Thu, 25 Feb 2016 11:02:27 +0900 From: Namhyung Kim <namhyung@...nel.org> To: Arnaldo Carvalho de Melo <acme@...nel.org> CC: Ingo Molnar <mingo@...nel.org>, Peter Zijlstra <peterz@...radead.org>, Jiri Olsa <jolsa@...nel.org>, LKML <linux-kernel@...r.kernel.org>, David Ahern <dsahern@...il.com>, Andi Kleen <andi@...stfloor.org>, Stephane Eranian <eranian@...gle.com>, Wang Nan <wangnan0@...wei.com> Subject: Re: [PATCH v7 05/18] perf hists: Introduce hist_entry__filter() Hi Arnaldo, On Wed, Feb 24, 2016 at 08:22:51PM -0300, Arnaldo Carvalho de Melo wrote: > Em Thu, Feb 25, 2016 at 12:13:37AM +0900, Namhyung Kim escreveu: > > +static int hist_entry__socket_filter(struct hist_entry *he, int type, const void *arg) > > +{ > > + int socket = *(const int *)arg; > > + > > + if (type != HIST_FILTER__SOCKET) > > + return -1; > > + > > + return socket >= 0 && he->socket != socket; > > 'socket' is a function in sys/socket.h, and in older systems this file, > tools/perf/util/sort.c, ends up including that header, causing: > > CC /tmp/build/perf/util/sort.o > cc1: warnings being treated as errors > util/sort.c: In function ‘hist_entry__socket_filter’: > util/sort.c:479: error: declaration of ‘socket’ shadows a global > declaration > /usr/include/sys/socket.h:105: error: shadowed declaration is here > > I fixed it renaming it to 'sk'. Oh, thank you for fixing this! Thanks, Namhyung
Powered by blists - more mailing lists