linux-kernel - Re: [PATCH v3 6/6] PCI: xilinx: Allow build on MIPS platforms

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <20160225154326.GE8120@localhost>
Date:	Thu, 25 Feb 2016 09:43:26 -0600
From:	Bjorn Helgaas <helgaas@...nel.org>
To:	Paul Burton <paul.burton@...tec.com>
Cc:	Rob Herring <robh@...nel.org>,
	Linux-MIPS <linux-mips@...ux-mips.org>,
	Bharat Kumar Gogada <bharatku@...inx.com>,
	Michal Simek <michal.simek@...inx.com>,
	Ravikiran Gummaluri <rgummal@...inx.com>,
	Ley Foon Tan <lftan@...era.com>,
	Arnd Bergmann <arnd@...db.de>,
	Bjorn Helgaas <bhelgaas@...gle.com>,
	Phil Edworthy <phil.edworthy@...esas.com>,
	Scott Branden <sbranden@...adcom.com>,
	Stanimir Varbanov <svarbanov@...sol.com>,
	"linux-kernel@...r.kernel.org" <linux-kernel@...r.kernel.org>,
	Duc Dang <dhdang@....com>,
	"linux-pci@...r.kernel.org" <linux-pci@...r.kernel.org>,
	Gabriele Paoloni <gabriele.paoloni@...wei.com>,
	Marc Zyngier <marc.zyngier@....com>,
	Geert Uytterhoeven <geert+renesas@...der.be>,
	Ray Jui <rjui@...adcom.com>, Hauke Mehrtens <hauke@...ke-m.de>
Subject: Re: [PATCH v3 6/6] PCI: xilinx: Allow build on MIPS platforms

On Thu, Feb 04, 2016 at 05:53:25PM +0000, Paul Burton wrote:
> On Thu, Feb 04, 2016 at 11:46:28AM -0600, Rob Herring wrote:
> > On Thu, Feb 4, 2016 at 10:10 AM, Paul Burton <paul.burton@...tec.com> wrote:
> > > Allow the xilinx-pcie driver to be built on MIPS platforms. This will be
> > > used on the MIPS Boston board.
> > >
> > > Signed-off-by: Paul Burton <paul.burton@...tec.com>
> > >
> > > ---
> > >
> > > Changes in v3:
> > > - Split out from Boston patchset.
> > >
> > > Changes in v2: None
> > >
> > >  drivers/pci/host/Kconfig | 2 +-
> > >  1 file changed, 1 insertion(+), 1 deletion(-)
> > >
> > > diff --git a/drivers/pci/host/Kconfig b/drivers/pci/host/Kconfig
> > > index 75a6054..0aee193 100644
> > > --- a/drivers/pci/host/Kconfig
> > > +++ b/drivers/pci/host/Kconfig
> > > @@ -81,7 +81,7 @@ config PCI_KEYSTONE
> > >
> > >  config PCIE_XILINX
> > >         bool "Xilinx AXI PCIe host bridge support"
> > > -       depends on ARCH_ZYNQ
> > > +       depends on ARCH_ZYNQ || MIPS
> > 
> > Why don't you just remove the dependency? Then it gets better build coverage.
> > 
> > Rob
> 
> That seems like a call best made by whomever has to maintain this - if
> that's the preferred way to go I'm fine with it.

I'm in favor of removing the dependency if possible.  I guess Michal
would be the person to ack that.

Right now (in my current "next" branch),
drivers/pci/host/pcie-xilinx.c uses struct hw_pci, which is only
defined by arm.

Bjorn