linux-kernel - Re: [PATCH] x86/mm: fix slow_virt_to_phys() for X86

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <1456419790.15454.6.camel@hpe.com>
Date:	Thu, 25 Feb 2016 10:03:10 -0700
From:	Toshi Kani <toshi.kani@....com>
To:	Dexuan Cui <decui@...rosoft.com>, gregkh@...uxfoundation.org,
	akpm@...ux-foundation.org, tglx@...utronix.de, linux-mm@...ck.org,
	linux-kernel@...r.kernel.org,
	driverdev-devel@...uxdriverproject.org, jasowang@...hat.com
Cc:	olaf@...fle.de, apw@...onical.com, kys@...rosoft.com,
	haiyangz@...rosoft.com
Subject: Re: [PATCH] x86/mm: fix slow_virt_to_phys() for X86_PAE again

On Thu, 2016-02-25 at 01:58 -0800, Dexuan Cui wrote:
> "d1cd12108346: x86, pageattr: Prevent overflow in slow_virt_to_phys() for
> X86_PAE"
> was unintentionally removed by the recent
> "34437e67a672: x86/mm: Fix slow_virt_to_phys() to handle large PAT bit".
> 
> And, the variable 'phys_addr' was defined as "unsigned long" by mistake
> -- it should
> be "phys_addr_t".
> 
> As a result, Hyper-V network driver in 32-PAE Linux guest can't work
> again.
> 
> Fixes: "commmit 34437e67a672: x86/mm: Fix slow_virt_to_phys() to handle
> large PAT bit"
> Signed-off-by: Dexuan Cui <decui@...rosoft.com>
> Cc: Toshi Kani <toshi.kani@....com>
> Cc: Andrew Morton <akpm@...ux-foundation.org>
> Cc: Thomas Gleixner <tglx@...utronix.de>
> Cc: K. Y. Srinivasan <kys@...rosoft.com>
> Cc: Haiyang Zhang <haiyangz@...rosoft.com>
> Cc: gregkh@...uxfoundation.org
> Cc: linux-mm@...ck.org
> Cc: olaf@...fle.de
> Cc: apw@...onical.com
> Cc: jasowang@...hat.com
> Cc: stable@...r.kernel.org

Thanks for the fix and adding the comment to explain the trick!  The change
looks good to me.

Reviewed-by: Toshi Kani <toshi.kani@....com>

-Toshi