linux-kernel - Re: [PATCH v2] mfd: syscon: allow to register syscon with a device

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <1456421257.3268.18.camel@pengutronix.de>
Date:	Thu, 25 Feb 2016 18:27:37 +0100
From:	Philipp Zabel <p.zabel@...gutronix.de>
To:	Arnd Bergmann <arnd@...db.de>
Cc:	Lee Jones <lee.jones@...aro.org>,
	Alexander Shiyan <shc_work@...l.ru>,
	Pankaj Dubey <pankaj.dubey@...sung.com>,
	Pawel Moll <pawel.moll@....com>,
	Wolfram Sang <wsa@...-dreams.de>,
	Peter Seiderer <ps.report@....net>,
	Tushar Behera <tushar.behera@...aro.org>,
	linux-kernel@...r.kernel.org, kernel@...gutronix.de
Subject: Re: [PATCH v2] mfd: syscon: allow to register syscon with a device

Hi Arnd,

Am Mittwoch, den 24.02.2016, 17:26 +0100 schrieb Arnd Bergmann:
> On Wednesday 24 February 2016 16:02:28 Philipp Zabel wrote:
> > > > @@ -473,6 +474,12 @@ static const struct of_device_id imx6q_pinctrl_of_match[] = {
> > > >  
> > > >  static int imx6q_pinctrl_probe(struct platform_device *pdev)
> > > >  {
> > > > +       struct device_node *syscon_np;
> > > > +
> > > > +       syscon_np = of_find_compatible_node(NULL, NULL, "fsl,imx6q-iomuxc-gpr");
> > > > +       if (syscon_np)
> > > > +               syscon_register(&pdev->dev, syscon_np);
> > > > +
> > > >         return imx_pinctrl_probe(pdev, &imx6q_pinctrl_info);
> > > >  }
> > > >  
> > > > The pinctrl driver is probed at arch_initcall time.
> > > 
> > > I still don't see it where you are getting with this. Is this just for
> > > the debugfs interface or is there something else this does on top of
> > > that?
> > 
> > Sorry, yes, this is about the missing debugfs functionality.
> 
> Ok, so maybe there is a different way of doing this: If I understood
> it correctly, we now lost the debugfs handling on all syscon nodes?
> 
> Should we try to come up with a way to bring it back for all of them
> then, rather than having to do it per device?
> 
> I can see two possible ways of doing that:
> 
> a) change the regmap code to provide a debugfs interface for all
>    regmaps, including those without a device
> b) change the syscon driver to explicitly register the debugfs
>    interface at a later point in boot when the devices become
>    available

Thanks, b) seems to fit well for the i.MX IOMUXC. I have sent a patch to
use regmap_attach_dev for that.

regards
Philipp