linux-kernel - [PATCH] selftests: media_dcevice_test fix to handle ioctl failure case

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [day] [month] [year] [list]

Message-Id: <1456422255-5207-1-git-send-email-shuahkh@osg.samsung.com>
Date:	Thu, 25 Feb 2016 10:44:15 -0700
From:	Shuah Khan <shuahkh@....samsung.com>
To:	linux-kselftest@...r.kernel.org
Cc:	Shuah Khan <shuahkh@....samsung.com>, linux-kernel@...r.kernel.org,
	mchehab@....samsung.com, laurent.pinchart@...asonboard.com
Subject: [PATCH] selftests: media_dcevice_test fix to handle ioctl failure case

Fix to print information returned by ioctl only when
it returns success.

Signed-off-by: Shuah Khan <shuahkh@....samsung.com>
---
 tools/testing/selftests/media_tests/media_device_test.c | 5 +++--
 1 file changed, 3 insertions(+), 2 deletions(-)

diff --git a/tools/testing/selftests/media_tests/media_device_test.c b/tools/testing/selftests/media_tests/media_device_test.c
index a47880b..7a4d613 100644
--- a/tools/testing/selftests/media_tests/media_device_test.c
+++ b/tools/testing/selftests/media_tests/media_device_test.c
@@ -86,8 +86,9 @@ int main(int argc, char **argv)
 		ret = ioctl(fd, MEDIA_IOC_DEVICE_INFO, &mdi);
 		if (ret < 0)
 			printf("Media Device Info errno %s\n", strerror(errno));
-		printf("Media device model %s driver %s\n",
-			mdi.model, mdi.driver);
+		else
+			printf("Media device model %s driver %s\n",
+				mdi.model, mdi.driver);
 		sleep(10);
 		count++;
 	}
-- 
2.5.0