linux-kernel - Re: [PATCH 3/3] perf script: Remove duplicated code and needless a script_spec_

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Date:	Fri, 26 Feb 2016 04:17:56 +0900
From:	Taeung Song <treeze.taeung@...il.com>
To:	Arnaldo Carvalho de Melo <arnaldo.melo@...il.com>,
	Jiri Olsa <jolsa@...hat.com>
Cc:	linux-kernel@...r.kernel.org, Jiri Olsa <jolsa@...nel.org>,
	Namhyung Kim <namhyung@...nel.org>,
	Ingo Molnar <mingo@...nel.org>
Subject: Re: [PATCH 3/3] perf script: Remove duplicated code and needless a
 script_spec__findnew()



On 02/26/2016 04:16 AM, Arnaldo Carvalho de Melo wrote:
> Em Thu, Feb 25, 2016 at 08:02:22PM +0100, Jiri Olsa escreveu:
>> On Fri, Feb 26, 2016 at 12:13:10AM +0900, Taeung Song wrote:
>>> script_spec_register() called two functions
>>> script_spec__find() and script_spec__findnew().
>>> But script_spec__find() was called two times.
>>>
>>> So remove script_spec__findnew() and make
>>> script_spec_register() only call once script_spec__find().
>>>
>>> Cc: Jiri Olsa <jolsa@...nel.org>
>>> Signed-off-by: Taeung Song <treeze.taeung@...il.com>
>>
>> Acked-by: Jiri Olsa <jolsa@...nel.org>
>
> Looks good, applied.
>
> Thanks,
>
> - Arnaldo

Thank you!!

Taeung