linux-kernel - Re: [PATCH 42/50] pinctrl: pic32: Use devm_pinctrl

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Date:	Thu, 25 Feb 2016 13:30:43 -0700
From:	Joshua Henderson <joshua.henderson@...rochip.com>
To:	Laxman Dewangan <ldewangan@...dia.com>, <linus.walleij@...aro.org>,
	<corbet@....net>, <lee@...nel.org>
CC:	<linux-doc@...r.kernel.org>, <linux-kernel@...r.kernel.org>,
	<linux-gpio@...r.kernel.org>,
	<linux-rpi-kernel@...ts.infradead.org>,
	<linux-arm-kernel@...ts.infradead.org>,
	<bcm-kernel-feedback-list@...adcom.com>,
	<linux-mediatek@...ts.infradead.org>
Subject: Re: [PATCH 42/50] pinctrl: pic32: Use devm_pinctrl_register() for
 pinctrl registration

On 02/24/2016 06:16 AM, Laxman Dewangan wrote:
> Use devm_pinctrl_register() for pin control registration.
> 
> Signed-off-by: Laxman Dewangan <ldewangan@...dia.com>

Reviewed-by: Joshua Henderson <joshua.henderson@...rochip.com>

Thanks,
Josh

> ---
>  drivers/pinctrl/pinctrl-pic32.c | 3 ++-
>  1 file changed, 2 insertions(+), 1 deletion(-)
> 
> diff --git a/drivers/pinctrl/pinctrl-pic32.c b/drivers/pinctrl/pinctrl-pic32.c
> index 0b07d4b..2a3fcd6 100644
> --- a/drivers/pinctrl/pinctrl-pic32.c
> +++ b/drivers/pinctrl/pinctrl-pic32.c
> @@ -2194,7 +2194,8 @@ static int pic32_pinctrl_probe(struct platform_device *pdev)
>  	pic32_pinctrl_desc.custom_params = pic32_mpp_bindings;
>  	pic32_pinctrl_desc.num_custom_params = ARRAY_SIZE(pic32_mpp_bindings);
>  
> -	pctl->pctldev = pinctrl_register(&pic32_pinctrl_desc, &pdev->dev, pctl);
> +	pctl->pctldev = devm_pinctrl_register(&pdev->dev, &pic32_pinctrl_desc,
> +					      pctl);
>  	if (IS_ERR(pctl->pctldev)) {
>  		dev_err(&pdev->dev, "Failed to register pinctrl device\n");
>  		return PTR_ERR(pctl->pctldev);
>