linux-kernel - Re: [PATCH] clk: shmobile: Free 'clock' on error path

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <CAMuHMdUHVm0ZNfhxv_=sK3z6BjaJK0OxRun8GzfYg0w+HnX7VQ@mail.gmail.com>
Date:	Thu, 25 Feb 2016 21:32:04 +0100
From:	Geert Uytterhoeven <geert@...ux-m68k.org>
To:	Stephen Boyd <sboyd@...eaurora.org>
Cc:	Michael Turquette <mturquette@...libre.com>,
	"linux-kernel@...r.kernel.org" <linux-kernel@...r.kernel.org>,
	linux-clk <linux-clk@...r.kernel.org>,
	Geert Uytterhoeven <geert+renesas@...der.be>
Subject: Re: [PATCH] clk: shmobile: Free 'clock' on error path

Hi Stephen,

On Thu, Feb 25, 2016 at 9:26 PM, Stephen Boyd <sboyd@...eaurora.org> wrote:
> We forgot to free this clock when we return early in this code.
>
> Cc: Geert Uytterhoeven <geert+renesas@...der.be>
> Signed-off-by: Stephen Boyd <sboyd@...eaurora.org>

Acked-by: Geert Uytterhoeven <geert+renesas@...der.be>

> ---
>  drivers/clk/shmobile/renesas-cpg-mssr.c | 1 +
>  1 file changed, 1 insertion(+)
>
> diff --git a/drivers/clk/shmobile/renesas-cpg-mssr.c b/drivers/clk/shmobile/renesas-cpg-mssr.c
> index 925b6007e531..58e24b326a48 100644
> --- a/drivers/clk/shmobile/renesas-cpg-mssr.c
> +++ b/drivers/clk/shmobile/renesas-cpg-mssr.c
> @@ -348,6 +348,7 @@ static void __init cpg_mssr_register_mod_clk(const struct mssr_mod_clk *mod,
>  #else
>                         dev_dbg(dev, "Ignoring MSTP %s to prevent disabling\n",
>                                 mod->name);
> +                       kfree(clock);
>                         return;
>  #endif

I had hoped for the whole "#else /* !CLK_ENABLE_HAND_OFF */" branch
to be removed before anyone would start to fix silly issues like this ;-)

Gr{oetje,eeting}s,

                        Geert

--
Geert Uytterhoeven -- There's lots of Linux beyond ia32 -- geert@...ux-m68k.org

In personal conversations with technical people, I call myself a hacker. But
when I'm talking to journalists I just say "programmer" or something like that.
                                -- Linus Torvalds