linux-kernel - [PATCH, RESEND] ssb: host

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [thread-next>] [day] [month] [year] [list]

Message-Id: <1456433869-3919332-1-git-send-email-arnd@arndb.de>
Date:	Thu, 25 Feb 2016 21:57:43 +0100
From:	Arnd Bergmann <arnd@...db.de>
To:	Kalle Valo <kvalo@....qualcomm.com>
Cc:	linux-arm-kernel@...ts.infradead.org, Michael Buesch <m@...s.ch>,
	linux-wireless@...r.kernel.org,
	Rafał Miłecki <zajec5@...il.com>,
	Arnd Bergmann <arnd@...db.de>, linux-kernel@...r.kernel.org
Subject: [PATCH, RESEND] ssb: host_soc depends on sprom

Drivers that use the SSB sprom functionality typically 'select SSB_SPROM'
from Kconfig, but CONFIG_SSB_HOST_SOC misses this, which results in
a build failure unless at least one of the other drivers that selects
it is enabled:

drivers/built-in.o: In function `ssb_host_soc_get_invariants':
(.text+0x459494): undefined reference to `ssb_fill_sprom_with_fallback'

This adds the same select statement that is used elsewhere.

Signed-off-by: Arnd Bergmann <arnd@...db.de>
Fixes: 541c9a84cd85 ("ssb: pick SoC invariants code from MIPS BCM47xx arch")
---
 drivers/ssb/Kconfig | 1 +
 1 file changed, 1 insertion(+)

I just noticed this hasn't shown up in linux-next yet, so I'm resending
it to ensure it's still on someone's radar. Please ignore the resend
if it's already in a tree that is not part of linux-next but will
be merged eventually.

See https://patchwork.linux-mips.org/patch/12091/ for the original
submission.

diff --git a/drivers/ssb/Kconfig b/drivers/ssb/Kconfig
index 0c675861623f..d8e4219c2324 100644
--- a/drivers/ssb/Kconfig
+++ b/drivers/ssb/Kconfig
@@ -83,6 +83,7 @@ config SSB_SDIOHOST
 config SSB_HOST_SOC
 	bool "Support for SSB bus on SoC"
 	depends on SSB && BCM47XX_NVRAM
+	select SSB_SPROM
 	help
 	  Host interface for a SSB directly mapped into memory. This is
 	  for some Broadcom SoCs from the BCM47xx and BCM53xx lines.
-- 
2.7.0