linux-kernel - Re: [PATCH] x86/mpx: Fix off-by-one comparison with nr

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <56D0A29C.9040504@linux.intel.com>
Date:	Fri, 26 Feb 2016 11:08:12 -0800
From:	Dave Hansen <dave.hansen@...ux.intel.com>
To:	Colin King <colin.king@...onical.com>,
	Thomas Gleixner <tglx@...utronix.de>,
	Ingo Molnar <mingo@...nel.org>,
	"H . Peter Anvin" <hpa@...ux.intel.com>, x86@...nel.org,
	Borislav Petkov <bp@...en8.de>,
	"Kirill A . Shutemov" <kirill.shutemov@...ux.intel.com>
Cc:	linux-kernel@...r.kernel.org
Subject: Re: [PATCH] x86/mpx: Fix off-by-one comparison with nr_registers

On 02/26/2016 10:55 AM, Colin King wrote:
> In the unlikely event that regno == nr_registers then we get an array
> overrun on regoff because the invalid register check is currently
> off-by-one. Fix this with a check that regno is >= nr_registers instead.
> 
> Detected with static analysis using CoverityScan.

Oh, the irony of an overrun in the MPX code!  Thanks for catching this.

Acked-by: Dave Hansen <dave.hansen@...el.com>