linux-kernel - Re: [PATCH] Input: gpio_keys_polled

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <CAMuHMdV8GZt0OwQvDTspuMLQTDDn-P=BLLmbNkXGExtTgYSpWQ@mail.gmail.com>
Date:	Fri, 26 Feb 2016 21:34:15 +0100
From:	Geert Uytterhoeven <geert@...ux-m68k.org>
To:	Dmitry Torokhov <dmitry.torokhov@...il.com>
Cc:	"linux-input@...r.kernel.org" <linux-input@...r.kernel.org>,
	Linus Walleij <linus.walleij@...aro.org>,
	Aaron Lu <aaron.lu@...el.com>,
	Mika Westerberg <mika.westerberg@...ux.intel.com>,
	"Rafael J. Wysocki" <rafael.j.wysocki@...el.com>,
	"linux-kernel@...r.kernel.org" <linux-kernel@...r.kernel.org>
Subject: Re: [PATCH] Input: gpio_keys_polled - keep button data constant

Hi Dmitry,

On Fri, Feb 26, 2016 at 7:50 PM, Dmitry Torokhov
<dmitry.torokhov@...il.com> wrote:
> Commit 633a21d80b4a ("input: gpio_keys_polled: Add support for GPIO
> descriptors") placed gpio descriptor into gpio_keys_button structure, which
> is supposed to be part of platform data and not modifiable by the driver.
> To keep the data constant, let's move the descriptor to
> gpio_keys_button_data structure instead.
>
> Signed-off-by: Dmitry Torokhov <dmitry.torokhov@...il.com>
> ---
>
> Compiled only, I do not have devices with polled keys...

If you're on DT, just change "gpio-keys" to "gpio-keys-polled", add
"poll-interval = <20>;", and everything should work fine.

Gr{oetje,eeting}s,

                        Geert

--
Geert Uytterhoeven -- There's lots of Linux beyond ia32 -- geert@...ux-m68k.org

In personal conversations with technical people, I call myself a hacker. But
when I'm talking to journalists I just say "programmer" or something like that.
                                -- Linus Torvalds