linux-kernel - Re: [PATCH 1/5] perf report: Fix comparing of dynamic entries

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <20160226212315.GC19398@krava.redhat.com>
Date:	Fri, 26 Feb 2016 22:23:15 +0100
From:	Jiri Olsa <jolsa@...hat.com>
To:	Namhyung Kim <namhyung@...nel.org>
Cc:	Arnaldo Carvalho de Melo <acme@...nel.org>,
	Ingo Molnar <mingo@...nel.org>,
	Peter Zijlstra <peterz@...radead.org>,
	Jiri Olsa <jolsa@...nel.org>,
	LKML <linux-kernel@...r.kernel.org>,
	David Ahern <dsahern@...il.com>,
	Andi Kleen <andi@...stfloor.org>,
	Stephane Eranian <eranian@...gle.com>,
	Wang Nan <wangnan0@...wei.com>
Subject: Re: [PATCH 1/5] perf report: Fix comparing of dynamic entries

On Sat, Feb 27, 2016 at 03:52:43AM +0900, Namhyung Kim wrote:
> When hist_entry__cmp() and hist_entry__collapse() are called, it should
> check the dynamic entry is comparing matching hists only.  Otherwise it
> might access different hists resulting in incorrect output.

the whole patchset looks good to me:

Acked-by: Jiri Olsa <jolsa@...nel.org>

thanks,
jirka