linux-kernel - Re: [PATCH v2] mfd: Provide MACRO to declare commonly defined MFD cell attributes

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite for Android: free password hash cracker in your pocket

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Date:	Fri, 26 Feb 2016 12:43:15 +0200
From:	Andy Shevchenko <andy.shevchenko@...il.com>
To:	Lee Jones <lee.jones@...aro.org>
Cc:	linux-arm Mailing List <linux-arm-kernel@...ts.infradead.org>,
	"linux-kernel@...r.kernel.org" <linux-kernel@...r.kernel.org>,
	Laxman Dewangan <ldewangan@...dia.com>,
	Linus Walleij <linus.walleij@...aro.org>
Subject: Re: [PATCH v2] mfd: Provide MACRO to declare commonly defined MFD
 cell attributes

On Wed, Feb 10, 2016 at 5:38 PM, Lee Jones <lee.jones@...aro.org> wrote:
> mfd: Provide MACRO to declare commonly defined MFD cell attributes
>

Commit message?


> +#define MFD_ARRAY_SIZE(arr) (sizeof(arr) / sizeof((arr)[0]))

What's wrong with ARRAY_SIZE() ?

> +
> +#define MFD_CELL_ALL(_name, _res, _pdata, _id, _compat, _match)                \

It misses pset. Which makes below set of macros is not sufficient.

> +       {                                                               \
> +               .name = (_name),                                        \
> +               .resources = (_res),                                    \
> +               .num_resources = MFD_ARRAY_SIZE((_res)),                \
> +               .platform_data = (_pdata),                              \
> +               .pdata_size = MFD_ARRAY_SIZE((_pdata)),                 \
> +               .of_compatible = (_compat),                             \
> +               .acpi_match = (_match),                                 \
> +               .id = _id,                                              \
> +       }
> +
> +#define OF_MFD_CELL(_name, _res, _pdata, _id, _compat)                 \
> +               MFD_CELL_ALL(_name, _res, _pdata, _id, _compat, NULL)   \
> +
> +#define ACPI_MFD_CELL(_name, _res, _pdata, _id, _match)                        \
> +               MFD_CELL_ALL(_name, _res, _pdata, _id, NULL, _match)    \
> +
> +#define MFD_CELL_BASIC(_name, _res, _pdata, _id)                       \
> +               MFD_CELL_ALL(_name, _res, _pdata, _id, NULL, NULL)      \
> +
> +#define MFD_CELL_NAME(_name)                                           \
> +               MFD_CELL_ALL(_name, NULL, NULL, 0, NULL, NULL)          \

-- 
With Best Regards,
Andy Shevchenko