lists.openwall.net | lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC | |
Open Source and information security mailing list archives
| ||
|
Date: Fri, 26 Feb 2016 14:35:08 +0000 From: Harvey Hunt <harvey.hunt@...tec.com> To: Boris Brezillon <boris.brezillon@...e-electrons.com>, David Woodhouse <dwmw2@...radead.org>, Brian Norris <computersforpeace@...il.com>, <linux-mtd@...ts.infradead.org> CC: Daniel Mack <daniel@...que.org>, Haojian Zhuang <haojian.zhuang@...il.com>, Robert Jarzmik <robert.jarzmik@...e.fr>, "Kukjin Kim" <kgene@...nel.org>, Krzysztof Kozlowski <k.kozlowski@...sung.com>, <linux-samsung-soc@...r.kernel.org>, <linux-arm-kernel@...ts.infradead.org>, Ralf Baechle <ralf@...ux-mips.org>, <linux-mips@...ux-mips.org>, "Nicolas Ferre" <nicolas.ferre@...el.com>, Jean-Christophe Plagniol-Villard <plagnioj@...osoft.com>, Alexandre Belloni <alexandre.belloni@...e-electrons.com>, Wenyou Yang <wenyou.yang@...el.com>, Josh Wu <rainyfeeling@...look.com>, Ezequiel Garcia <ezequiel.garcia@...e-electrons.com>, Maxime Ripard <maxime.ripard@...e-electrons.com>, Chen-Yu Tsai <wens@...e.org>, <linux-sunxi@...glegroups.com>, Stefan Agner <stefan@...er.ch>, Kyungmin Park <kyungmin.park@...sung.com>, Greg Kroah-Hartman <gregkh@...uxfoundation.org>, <devel@...verdev.osuosl.org>, <linux-kernel@...r.kernel.org>, "punnaiah choudary kalluri" <punnaia@...inx.com>, Priit Laes <plaes@...es.org>, "Kamal Dasu" <kdasu.kdev@...il.com>, <bcm-kernel-feedback-list@...adcom.com>, <linux-api@...r.kernel.org> Subject: Re: [PATCH v3 07/52] mtd: nand: core: use mtd_ooblayout_xxx() helpers where appropriate Hi Boris, On 26/02/16 00:57, Boris Brezillon wrote: > The mtd_ooblayout_xxx() helper functions have been added to avoid direct > accesses to the ecclayout field, and thus ease for future reworks. > Use these helpers in all places where the oobfree[] and eccpos[] arrays > where directly accessed. > > Signed-off-by: Boris Brezillon <boris.brezillon@...e-electrons.com> > --- > drivers/mtd/nand/nand_base.c | 183 +++++++++++++++++++------------------------ > drivers/mtd/nand/nand_bch.c | 3 +- > 2 files changed, 82 insertions(+), 104 deletions(-) > > diff --git a/drivers/mtd/nand/nand_base.c b/drivers/mtd/nand/nand_base.c > index 91672bf..17504f2 100644 [...] I just pulled your nand/ecclayout branch from github and tested out your latest patchset "mtd: rework ECC layout definition" on a Ci20 (jz4780_{nand,bch}) and noticed that my board was failing to boot. I bisected to this patch, here is the kernel's output during boot: 479556d ("mtd: nand: core: use mtd_ooblayout_xxx() helpers where appropriate"): [ 0.256349] nand: device found, Manufacturer ID: 0x2c, Chip ID: 0x88 [ 0.262860] nand: Micron MT29F64G08CBAAAWP [ 0.266970] nand: 8192 MiB, MLC, erase size: 2048 KiB, page size: 8192, OOB size: 448 [ 0.274856] jz4780-nand 1b000000.nand-controller: using hardware BCH (strength 24, size 1024, bytes 42) [ 0.288982] Bad block table not found for chip 0 [ 0.297673] Bad block table not found for chip 0 [ 0.302328] Scanning device for bad blocks [ 0.320135] Bad eraseblock 90 at 0x00000b400000 [ 0.324829] Bad eraseblock 91 at 0x00000b600000 [ 0.931085] Bad eraseblock 4092 at 0x0001ff800000 [ 0.935947] Bad eraseblock 4093 at 0x0001ffa00000 [ 0.944878] nand_bbt: error while writing bad block table -34 [ 0.950666] jz4780-nand: probe of 1b000000.nand-controller failed with error -34 [ 0.958302] UBI error: cannot open mtd 3, error -19 [ 0.963002] UBI error: cannot open mtd 4, error -19[ 0.970419] clk: Not disabling unused clocks [ 0.975011] UBIFS error (pid: 1): cannot open "ubi1:root", error -19VFS: Cannot open root device "ubi1:root" or unknown-block(0,0): error -19 [ 0.987810] Please append a correct "root=" boot option; here are the available partitions: [ 0.996210] Kernel panic - not syncing: VFS: Unable to mount root fs on unknown-block(0,0) [ 1.004498] Rebooting in 10 seconds.. 6625d32 ("mtd: use mtd_ooblayout_xxx() helpers where appropriate"): [ 0.256232] nand: device found, Manufacturer ID: 0x2c, Chip ID: 0x88 [ 0.262745] nand: Micron MT29F64G08CBAAAWP [ 0.266854] nand: 8192 MiB, MLC, erase size: 2048 KiB, page size: 8192, OOB size: 448 [ 0.274739] jz4780-nand 1b000000.nand-controller: using hardware BCH (strength 24, size 1024, bytes 42) [ 0.285993] Bad block table found at page 1048320, version 0x01 [ 0.294353] Bad block table found at page 1048064, version 0x01 [ 0.301523] nand_read_bbt: bad block at 0x00000b400000 [ 0.306677] nand_read_bbt: bad block at 0x00000b600000 [ 0.312289] 5 ofpart partitions found on MTD device 1b000000.nand-controller.1 [ 0.319553] Creating 5 MTD partitions on "1b000000.nand-controller.1": [ 0.326098] 0x000000000000-0x000000800000 : "u-boot-spl" [ 0.331757] 0x000000800000-0x000000a00000 : "u-boot" [ 0.337185] 0x000000a00000-0x000000c00000 : "u-boot-env" [ 0.342903] 0x000000c00000-0x000004c00000 : "boot" [ 0.348109] 0x000004c00000-0x000200000000 : "system" [ 0.354284] ubi0 error: ubi_attach_mtd_dev: More than 64 PEBs are needed for fastmap, sorry. [...] I'll look into this more later today, but wanted to run it by you in case you have any thoughts. Thanks, Harvey
Powered by blists - more mailing lists