linux-kernel - Re: [PATCH v2 2/3] hvc_xen: fix xenboot for DomUs

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <alpine.DEB.2.02.1602261651560.4219@kaball.uk.xensource.com>
Date:	Fri, 26 Feb 2016 16:57:22 +0000
From:	Stefano Stabellini <stefano.stabellini@...citrix.com>
To:	Boris Ostrovsky <boris.ostrovsky@...cle.com>
CC:	Stefano Stabellini <stefano.stabellini@...citrix.com>,
	<xen-devel@...ts.xensource.com>, <linux-kernel@...r.kernel.org>,
	<david.vrabel@...rix.com>, <konrad.wilk@...cle.com>
Subject: Re: [PATCH v2 2/3] hvc_xen: fix xenboot for DomUs

On Fri, 26 Feb 2016, Boris Ostrovsky wrote:
> On 02/26/2016 10:39 AM, Stefano Stabellini wrote:
> > On Thu, 25 Feb 2016, Boris Ostrovsky wrote:
> > > On 02/25/2016 07:10 AM, Stefano Stabellini wrote:
> > > > The xenboot early console has been partially broken for DomU for a long
> > > > time: the output would only go to the hypervisor via hypercall
> > > > (HYPERVISOR_console_io), while it wouldn't actually go to the DomU
> > > > console. The reason is that domU_write_console would return early as no
> > > > xencons structs are configured for it.
> > > > 
> > > > Add an appropriate xencons struct for xenboot from the xenboot setup
> > > > callback.
> > > > 
> > > > Signed-off-by: Stefano Stabellini <stefano.stabellini@...citrix.com>
> > > > 
> > > > ---
> > > > Changes in v2:
> > > > - add return to xenboot_setup_console
> > > > ---
> > > >    drivers/tty/hvc/hvc_xen.c |   32 ++++++++++++++++++++++++++------
> > > >    1 file changed, 26 insertions(+), 6 deletions(-)
> > > > 
> > > > diff --git a/drivers/tty/hvc/hvc_xen.c b/drivers/tty/hvc/hvc_xen.c
> > > > index 68b8ec8..bf787aa 100644
> > > > --- a/drivers/tty/hvc/hvc_xen.c
> > > > +++ b/drivers/tty/hvc/hvc_xen.c
> > > > @@ -246,6 +246,18 @@ err:
> > > >    	return -ENODEV;
> > > >    }
> > > >    +static int xen_early_pv_console_init(struct xencons_info *info, int
> > > > vtermno)
> > > Nit: not sure whether "early" is the right word to use here: when called
> > > from
> > > xen_pv_console_init() it's not really on the early path.
> > What about xencons_info_pv_init?
> 
> Sure, that sounds good.
> 
> (BTW, I didn't mean that my R-b was conditional on this)

No problem. I made this change and committed the three patches to
for-linus-4.6, based on v4.5-rc5.