linux-kernel - [tip:perf/core] perf hists browser: Cleanup hist_browser__update_percent

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <tip-201fde73b111e7c31fdc0e9fa6bc4b73dfef699d@git.kernel.org>
Date:	Sat, 27 Feb 2016 01:42:00 -0800
From:	tip-bot for Namhyung Kim <tipbot@...or.com>
To:	linux-tip-commits@...r.kernel.org
Cc:	wangnan0@...wei.com, tglx@...utronix.de, peterz@...radead.org,
	dsahern@...il.com, acme@...hat.com, hpa@...or.com,
	eranian@...gle.com, linux-kernel@...r.kernel.org, jolsa@...nel.org,
	andi@...stfloor.org, namhyung@...nel.org, mingo@...nel.org
Subject: [tip:perf/core] perf hists browser: Cleanup
 hist_browser__update_percent_limit()

Commit-ID:  201fde73b111e7c31fdc0e9fa6bc4b73dfef699d
Gitweb:     http://git.kernel.org/tip/201fde73b111e7c31fdc0e9fa6bc4b73dfef699d
Author:     Namhyung Kim <namhyung@...nel.org>
AuthorDate: Fri, 26 Feb 2016 21:13:18 +0900
Committer:  Arnaldo Carvalho de Melo <acme@...hat.com>
CommitDate: Fri, 26 Feb 2016 11:20:36 -0300

perf hists browser: Cleanup hist_browser__update_percent_limit()

The previous patch introduced __rb_hierarchy_next() function with
various move direction like HMD_FORCE_CHILD but missed to change using
it some place.

Signed-off-by: Namhyung Kim <namhyung@...nel.org>
Cc: Andi Kleen <andi@...stfloor.org>
Cc: David Ahern <dsahern@...il.com>
Cc: Jiri Olsa <jolsa@...nel.org>
Cc: Peter Zijlstra <peterz@...radead.org>
Cc: Stephane Eranian <eranian@...gle.com>
Cc: Wang Nan <wangnan0@...wei.com>
Link: http://lkml.kernel.org/r/1456488800-28124-3-git-send-email-namhyung@kernel.org
Signed-off-by: Arnaldo Carvalho de Melo <acme@...hat.com>
---
 tools/perf/ui/browsers/hists.c | 7 +------
 1 file changed, 1 insertion(+), 6 deletions(-)

diff --git a/tools/perf/ui/browsers/hists.c b/tools/perf/ui/browsers/hists.c
index 6bcd767..904eaa7 100644
--- a/tools/perf/ui/browsers/hists.c
+++ b/tools/perf/ui/browsers/hists.c
@@ -2477,12 +2477,7 @@ static void hist_browser__update_percent_limit(struct hist_browser *hb,
 				     min_callchain_hits, &callchain_param);
 
 next:
-		/*
-		 * Tentatively set unfolded so that the rb_hierarchy_next()
-		 * can toggle children of folded entries too.
-		 */
-		he->unfolded = he->has_children;
-		nd = rb_hierarchy_next(nd);
+		nd = __rb_hierarchy_next(nd, HMD_FORCE_CHILD);
 
 		/* force to re-evaluate folding state of callchains */
 		he->init_have_children = false;