linux-kernel - Re: [PATCH v2 5/6] hisi_sas: add hisi_sas_slave

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <56D18FBC.8050501@suse.de>
Date:	Sat, 27 Feb 2016 19:59:56 +0800
From:	Hannes Reinecke <hare@...e.de>
To:	John Garry <john.garry@...wei.com>, JBottomley@...n.com,
	martin.petersen@...cle.com
Cc:	linuxarm@...wei.com, john.garry2@...l.dcu.ie,
	linux-scsi@...r.kernel.org, linux-kernel@...r.kernel.org
Subject: Re: [PATCH v2 5/6] hisi_sas: add hisi_sas_slave_configure()

On 02/25/2016 05:42 PM, John Garry wrote:
> In high-datarate aging tests, it is found that the
> SCSI framework can periodically issue lu resets as
> some commands timeout.
> Response TASK SET FULL and SAS_QUEUE_FULL may be
> returned many times for the same command, causing the
> timeouts.
> The SAS_QUEUE_FULL errors come from
> TRANS_TX_CREDIT_TIMEOUT_ERR, TRANS_TX_CLOSE_NORMAL_ERR,
> and TRANS_TX_ERR_FRAME_TXED errors. They do not mean
> that the queue is full in the host, but rather it is
> equivalent to meaning the queue is full for the sdev.
> To overcome this, the queue depth for the sdev is
> reduced to 64 (from 256, set in sas_slave_configure()).
> Normally error code SAS_QUEUE_FULL will result in the
> sdev queue depth falling, but it falls too slowly during
> high-datarate tests and commands timeout before it
> has fallen to an adequete level from original value.
> 
> Signed-off-by: John Garry <john.garry@...wei.com>
> ---
Reviewed-by: Hannes Reinecke <hare@...e.de>

Cheers,

Hannes
-- 
Dr. Hannes Reinecke		      zSeries & Storage
hare@...e.de			      +49 911 74053 688
SUSE LINUX Products GmbH, Maxfeldstr. 5, 90409 Nürnberg
GF: J. Hawn, J. Guild, F. Imendörffer, HRB 16746 (AG Nürnberg)