linux-kernel - Re: [PATCH v3] staging: octeon: Convert create_singlethread

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <20160228130950.GJ3965@htj.duckdns.org>
Date:	Sun, 28 Feb 2016 08:09:50 -0500
From:	Tejun Heo <tj@...nel.org>
To:	Bhaktipriya Shridhar <bhaktipriya96@...il.com>
Cc:	gregkh@...uxfoundation.org, aaro.koskinen@....fi,
	cristina.moraru09@...il.com, avid.daney@...ium.com,
	david.daney@...ium.com, ralf@...ux-mips.org,
	paul.martin@...ethink.co.uk, arnd@...db.de, joe@...ches.com,
	aybuke.147@...il.com, linux-kernel@...r.kernel.org,
	devel@...verdev.osuosl.org
Subject: Re: [PATCH v3] staging: octeon: Convert
 create_singlethread_workqueue()

Hello,

On Sat, Feb 27, 2016 at 11:21:47PM +0530, Bhaktipriya Shridhar wrote:
> With conccurency managed workqueues, use of dedicated workqueues can
> be replaced by system_wq. Drop cvm_oct_poll_queue by using system_wq.
> 
> There are multiple work items per cvm_oct_poll_queue (viz.
> cvm_oct_rx_refill_work, port_periodic_work) and different
> cvm_oct_poll_queues need not be be ordered. Hence, concurrency
> can be increased by switching to system_wq.
> 
> All work items are sync canceled in cvm_oct_remove() so it
> is guaranteed that no work is in flight by the time exit path runs.
> 
> Signed-off-by: Bhaktipriya Shridhar <bhaktipriya96@...il.com>

For the workqueue part,

Acked-by: Tejun Heo <tj@...nel.org>

Thanks.

-- 
tejun