linux-kernel - Re: [PATCH] firmware: change kernel read fail to dev

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Date:	Sun, 28 Feb 2016 21:58:42 +0100
From:	"Luis R. Rodriguez" <mcgrof@...e.com>
To:	"Luis R. Rodriguez" <mcgrof@...nel.org>
Cc:	jmorris@...ei.org, ming.lei@...onical.com,
	zohar@...ux.vnet.ibm.com, gregkh@...uxfoundation.org,
	keescook@...omium.org, linux-kernel@...r.kernel.org,
	linux-security-module@...r.kernel.org, hkallweit1@...il.com
Subject: Re: [PATCH] firmware: change kernel read fail to dev_dbg()

On Sat, Feb 27, 2016 at 03:16:03PM -0800, Luis R. Rodriguez wrote:
> When we now use the new kernel_read_file_from_path() we
> are reporting a failure when we iterate over all the paths
> possible for firmware. Before using kernel_read_file_from_path()
> we only reported a failure once we confirmed a file existed
> with filp_open() but failed with fw_read_file_contents().
> 
> With kernel_read_file_from_path() both are done for us and
> we obviously are now reporting too much information given that
> some optional paths will always fail and clutter the logs.
> 
> fw_get_filesystem_firmware() already has a check for failure
> and uses an internal flag, FW_OPT_NO_WARN, to let users
> warn or not warn. For instance request_firmware_direct()
> does not warn as this can be used for optional firmware
> as it has no usermode helper fallback. In the future we
> may want to change this, given everyone is disabling the
> usermode helper anyway now, but for now keep reporting
> only as was designed. request_firmware_direct() will
> continue to not report errors as it was designed not to.
> 
> Reported-by: Heiner Kallweit <hkallweit1@...il.com>
> Cc: Heiner Kallweit <hkallweit1@...il.com>
> Cc: Mimi Zohar <zohar@...ux.vnet.ibm.com>
> Cc: Kees Cook <keescook@...omium.org>
> Signed-off-by: Luis R. Rodriguez <mcgrof@...nel.org>
> ---
> 
> Note, this is a fix for a small issue reported by Heiner after
> Mimi's common kernel file loader changes were merged on James tree.
> I'm following up through James. If this should go through someone
> else's tree feel free to coordiante accordingly.

I'll be replacing this shortly with a v2.

  Luis