linux-kernel - Re: [PATCH v18 0/9] Compile-time stack metadata validation

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Date:	Sun, 28 Feb 2016 07:52:37 +0100
From:	Ingo Molnar <mingo@...nel.org>
To:	Josh Poimboeuf <jpoimboe@...hat.com>
Cc:	Thomas Gleixner <tglx@...utronix.de>,
	Ingo Molnar <mingo@...hat.com>,
	"H. Peter Anvin" <hpa@...or.com>, x86@...nel.org,
	linux-kernel@...r.kernel.org, live-patching@...r.kernel.org,
	Michal Marek <mmarek@...e.cz>,
	Peter Zijlstra <peterz@...radead.org>,
	Andy Lutomirski <luto@...nel.org>,
	Borislav Petkov <bp@...en8.de>,
	Linus Torvalds <torvalds@...ux-foundation.org>,
	Andi Kleen <andi@...stfloor.org>,
	Pedro Alves <palves@...hat.com>,
	Namhyung Kim <namhyung@...il.com>,
	Bernd Petrovitsch <bernd@...rovitsch.priv.at>,
	Chris J Arges <chris.j.arges@...onical.com>,
	Andrew Morton <akpm@...ux-foundation.org>,
	Jiri Slaby <jslaby@...e.cz>,
	Arnaldo Carvalho de Melo <acme@...nel.org>
Subject: Re: [PATCH v18 0/9] Compile-time stack metadata validation


FYI, I got this build failure on allmodconfig-x86-64:

  objtool.c:134:1: error: control reaches end of non-void function [-Werror=return-type]

that was with:

  gcc version 4.8.3 20140911 (Red Hat 4.8.3-7) (GCC) 

GCC 5.2.1 does not trigger this warning, which is I suspect why you have not seen 
this in your own testing.

I applied the fix below: all paths that generate a nonzero error do an explicit 
exit(), so return 0 is fine here.

Thanks,

	Ingo

=====================>

 tools/objtool/objtool.c | 2 ++
 1 file changed, 2 insertions(+)

diff --git a/tools/objtool/objtool.c b/tools/objtool/objtool.c
index 4e53d272c0c3..46c326db4f46 100644
--- a/tools/objtool/objtool.c
+++ b/tools/objtool/objtool.c
@@ -131,4 +131,6 @@ int main(int argc, const char **argv)
 		cmd_usage();
 
 	handle_internal_command(argc, argv);
+
+	return 0;
 }