linux-kernel - Re: [PATCH 1/7] extcon: palmas: Drop IRQF_EARLY

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite for Android: free password hash cracker in your pocket

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Date:	Mon, 29 Feb 2016 11:22:08 +0900
From:	Chanwoo Choi <cw00.choi@...sung.com>
To:	Grygorii Strashko <grygorii.strashko@...com>,
	Lee Jones <lee.jones@...aro.org>,
	Alessandro Zummo <a.zummo@...ertech.it>,
	MyungJoo Ham <myungjoo.ham@...sung.com>,
	Lars-Peter Clausen <lars@...afoo.de>
Cc:	rtc-linux@...glegroups.com, linux-iio@...r.kernel.org,
	linux-kernel@...r.kernel.org, nsekhar@...com,
	linux-omap@...r.kernel.org, Tony Lindgren <tony@...mide.com>,
	Roger Quadros <rogerq@...com>, Nishanth Menon <nm@...com>
Subject: Re: [PATCH 1/7] extcon: palmas: Drop IRQF_EARLY_RESUME flag

Hi Grygorii,

On 2016년 02월 27일 00:42, Grygorii Strashko wrote:
> Palams extcon IRQs are nested threaded and wired to the Palmas
> inerrupt controller. So, this flag is not required for nested irqs
> anymore, since commit 3c646f2c6aa9 ("genirq: Don't suspend
> nested_thread irqs over system suspend") was merged.
> 
> Cc: MyungJoo Ham <myungjoo.ham@...sung.com>
> Cc: Chanwoo Choi <cw00.choi@...sung.com>
> Cc: Tony Lindgren <tony@...mide.com>
> Cc: Lee Jones <lee.jones@...aro.org>
> Cc: Roger Quadros <rogerq@...com>
> Cc: Nishanth Menon <nm@...com>
> Signed-off-by: Grygorii Strashko <grygorii.strashko@...com>
> ---
>  drivers/extcon/extcon-palmas.c | 4 ++--
>  1 file changed, 2 insertions(+), 2 deletions(-)
> 
> diff --git a/drivers/extcon/extcon-palmas.c b/drivers/extcon/extcon-palmas.c
> index 93c30a8..0a861b3 100644
> --- a/drivers/extcon/extcon-palmas.c
> +++ b/drivers/extcon/extcon-palmas.c
> @@ -266,7 +266,7 @@ static int palmas_usb_probe(struct platform_device *pdev)
>  				palmas_usb->id_irq,
>  				NULL, palmas_id_irq_handler,
>  				IRQF_TRIGGER_FALLING | IRQF_TRIGGER_RISING |
> -				IRQF_ONESHOT | IRQF_EARLY_RESUME,
> +				IRQF_ONESHOT,
>  				"palmas_usb_id", palmas_usb);
>  		if (status < 0) {
>  			dev_err(&pdev->dev, "can't get IRQ %d, err %d\n",
> @@ -304,7 +304,7 @@ static int palmas_usb_probe(struct platform_device *pdev)
>  				palmas_usb->vbus_irq, NULL,
>  				palmas_vbus_irq_handler,
>  				IRQF_TRIGGER_FALLING | IRQF_TRIGGER_RISING |
> -				IRQF_ONESHOT | IRQF_EARLY_RESUME,
> +				IRQF_ONESHOT,
>  				"palmas_usb_vbus", palmas_usb);
>  		if (status < 0) {
>  			dev_err(&pdev->dev, "can't get IRQ %d, err %d\n",
> 

Applied it on extcon git.

Thanks,
Chanwoo Choi