linux-kernel - Re: [PATCH] staging: rtl8192e: rtllib_softmac.c: Remove multiple blank lines

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Date:	Mon, 29 Feb 2016 16:41:27 +0530
From:	Vaishali Thakkar <vaishali.thakkar@...cle.com>
To:	Tapan Prakash T <tapanprakasht@...il.com>,
	gregkh@...uxfoundation.org, mateusz.kulikowski@...il.com,
	vthakkar1994@...il.com
Cc:	devel@...verdev.osuosl.org, linux-kernel@...r.kernel.org
Subject: Re: [PATCH] staging: rtl8192e: rtllib_softmac.c: Remove multiple
 blank lines



On Sunday 28 February 2016 08:18 PM, Tapan Prakash T wrote:
> Fixed blank lines issues reported by checkpatch.pl
Hi,

I can see that you have sent 3 patches for the same file. But they are
sent as separate patches. So, this might be confusing for the maintainer.

So, in this case these are some points you need to keep in mind:

1. You can send a single patch for the same warnings/errors in the same
file or directory covering all occurrences.

2. If you want to send patches for different errors in a single file then you
need to send a patch in the form of a patchset.

I think this should help you with understanding my point in a better way:

https://www.kernel.org/doc/Documentation/SubmittingPatches

> Signed-off-by: Tapan Prakash T <tapanprakasht@...il.com>
> ---
>  drivers/staging/rtl8192e/rtllib_softmac.c | 2 --
>  1 file changed, 2 deletions(-)
>
> diff --git a/drivers/staging/rtl8192e/rtllib_softmac.c b/drivers/staging/rtl8192e/rtllib_softmac.c
> index 25b5b5e..b40298b 100644
> --- a/drivers/staging/rtl8192e/rtllib_softmac.c
> +++ b/drivers/staging/rtl8192e/rtllib_softmac.c
> @@ -13,7 +13,6 @@
>   * released under the GPL
>   */
>  
> -
>  #include "rtllib.h"
>  
>  #include <linux/random.h>
> @@ -25,7 +24,6 @@
>  
>  static void rtllib_sta_wakeup(struct rtllib_device *ieee, short nl);
>  
> -
>  static short rtllib_is_54g(struct rtllib_network *net)
>  {
>  	return (net->rates_ex_len > 0) || (net->rates_len > 4);

-- 
Vaishali