linux-kernel - Re: [PATCH 5/7] regulator: act8865: Pass of_node via act8865_regulator

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <20160229113705.GA18327@sirena.org.uk>
Date:	Mon, 29 Feb 2016 20:37:05 +0900
From:	Mark Brown <broonie@...nel.org>
To:	Maarten ter Huurne <maarten@...ewalker.org>
Cc:	Wenyou Yang <wenyou.yang@...el.com>,
	Zubair Lutfullah Kakakhel <Zubair.Kakakhel@...tec.com>,
	Liam Girdwood <lgirdwood@...il.com>,
	linux-kernel@...r.kernel.org
Subject: Re: [PATCH 5/7] regulator: act8865: Pass of_node via
 act8865_regulator_data

On Sun, Feb 28, 2016 at 04:53:27PM +0100, Maarten ter Huurne wrote:

> +		struct regulator_config config = {
> +			.dev = dev,
> +			.regmap = act8865->regmap,
> +			.driver_data = act8865,
> +		};
> +		struct act8865_regulator_data *rdata;
>  		struct regulator_dev *rdev;
>  
> -		config.dev = dev;
> -		config.init_data = act8865_get_init_data(desc->id, pdata);
> -		config.of_node = of_node[i];
> -		config.driver_data = act8865;
> -		config.regmap = act8865->regmap;

This appears to be doing some unrelated refectoring of the code which
should be in a separate commit to make review clearer.

Download attachment "signature.asc" of type "application/pgp-signature" (474 bytes)