linux-kernel - Re: [RFC5 PATCH v6 00/21] ILP32 for ARM64

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite for Android: free password hash cracker in your pocket

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <2753057.uyT99zxyCM@wuerfel>
Date:	Mon, 29 Feb 2016 17:30:06 +0100
From:	Arnd Bergmann <arnd@...db.de>
To:	linux-arm-kernel@...ts.infradead.org
Cc:	Andreas Schwab <schwab@...e.de>, pinskia@...il.com,
	Prasun.Kapoor@...iumnetworks.com, catalin.marinas@....com,
	broonie@...nel.org, heiko.carstens@...ibm.com,
	linux-kernel@...r.kernel.org, agraf@...e.de,
	Nathan_Lynch@...tor.com, klimov.linux@...il.com,
	Yury Norov <ynorov@...iumnetworks.com>,
	"Zhangjian (Bamvor)" <bamvor.zhangjian@...wei.com>,
	joseph@...esourcery.com, schwidefsky@...ibm.com,
	jan.dakinevich@...il.com, christoph.muellner@...obroma-systems.com
Subject: Re: [RFC5 PATCH v6 00/21] ILP32 for ARM64

On Monday 29 February 2016 17:00:29 Andreas Schwab wrote:
> Arnd Bergmann <arnd@...db.de> writes:
> 
> > In https://github.com/norov/glibc/commit/5d4290435e428267171ece871539b76e1d079d11
> > you are defining a struct __kernel_stat64 in the glibc. Is this the expected
> > way to do it? I would have thought you'd get the definition from the kernel
> > headers.
> 
> The problem really is that struct stat64 does not match the kernel
> struct stat64.  The latter uses the broken st_ino, where the 64-bit
> inode is actually stored at the end of the structure, and there is
> padding *before* the 32-bit inode, not after (so you cannot overlay a
> 64-bit inode field in little endian mode).  You need to add the attached
> file as sysdeps/unix/sysv/linux/aarch64/bits/stat.h, then you can use
> the user-space struct stat64 to communicate with the *stat64 syscalls,
> and __kernel_stat64 is not needed any more.
> 

Ok, got it. So this is an unfortunate side-effect of using the same
'stat64' as arm32 does.

If it's really that broken, should we change the kernel (once more)
to use the layout of arm64 instead? That has the 64-bit time fields
though, so it might require similar hacks, unless we first merge
support for 64-bit time_t based syscalls (which seems unlikely
at this point, sorry for the delay on my end).

Is there possibly a way to reference the implementation that we
have for stat64 on arm32 rather than duplicating it?

	Arnd